Repository navigation
Translate the remaining untranslated strings from #5149 - #5591
Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit intoOct 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped, follow established localization and layout patterns, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
Addresses the remaining localization wiring and dialog alignment items from #5149 using existing UniGetUI translation mechanisms. The three new English keys enable future translations; other locales remain unchanged.
Changes:
- Localizes view-mode tooltips, accessibility names, and settings JSON file-filter labels.
- Adds English keys for both settings search prompts and the JSON filter label.
- Centers the integrity-violation dialog’s Close button text.
| File | Description |
|---|---|
src/UniGetUI.Avalonia/Views/SoftwarePages/AbstractPackagesPage.axaml |
Translates List, Grid, and Icons tooltips and accessibility names. |
src/UniGetUI.Avalonia/Views/DialogPages/IntegrityViolationDialog.axaml |
Centers the Close button’s content. |
src/UniGetUI.Avalonia/ViewModels/Pages/SettingsPages/GeneralViewModel.cs |
Translates import/export file-filter labels. |
src/Languages/lang_en.json |
Adds three missing translation keys. |
Review effort: Balanced
There was a problem hiding this comment.
🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉
Integration Details
{
"deliveryId": "722ed150-cf20-11f1-93a5-d81e0205ba16",
"headSha": "d0dca39b4ac103f267708a1053774c357c187636",
"reviewer": "copilot-pull-request-reviewer[bot]"
}
Gabriel Dufresne (GabrielDuf)
deleted the
fix/5149-untranslated-strings
branch
October 23, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5149.
Of the items reported in #5149, "Show illustrations on package lists" and the Bun description were already translated. The rest were still showing English (or misaligned) on
main:AbstractPackagesPage.axamlsetToolTip.Tipand their automation names as plain literals, so the existing locale entries ("Elenco", "Griglia", "Icone" in Italian) were never looked up. They now use{t:Translate ...}.GeneralViewModelbuilt the filter name from a literal; it now goes throughCoreTools.Translate.SettingsBasePagealready translated these, but neither key existed inlang_en.json, so translators never saw them. Both are added, together with "Settings JSON".MinWidthbut noHorizontalContentAlignment, so a short label such as "Chiudi" sat left-aligned. It now centers its content, matchingImmersiveConfirmationDialog.The three new keys are added to
lang_en.jsononly; other locales will show English for them until translated (bovirus (@bovirus) asked to have the keys added so the Italian can follow).Not in scope: the gendered-term point from the issue thread (e.g. "Enabled"/"Abilitato"/"Abilitata"), which needs per-context keys rather than a fix here.