Skip to content

Translate the remaining untranslated strings from #5149 - #5591

Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
fix/5149-untranslated-strings
Oct 23, 2026
Merged

Gabriel Dufresne (GabrielDuf) merged 1 commit into
mainfrom
fix/5149-untranslated-strings

Conversation

@GabrielDuf

@GabrielDuf Gabriel Dufresne (GabrielDuf) commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #5149.

Of the items reported in #5149, "Show illustrations on package lists" and the Bun description were already translated. The rest were still showing English (or misaligned) on main:

  • List / Grid / Icons tooltips - the view-mode selectors in AbstractPackagesPage.axaml set ToolTip.Tip and their automation names as plain literals, so the existing locale entries ("Elenco", "Griglia", "Icone" in Italian) were never looked up. They now use {t:Translate ...}.
  • "Settings JSON (*.json)" file filter - the settings import/export pickers in GeneralViewModel built the filter name from a literal; it now goes through CoreTools.Translate.
  • "Search package managers" / "Search settings" - SettingsBasePage already translated these, but neither key existed in lang_en.json, so translators never saw them. Both are added, together with "Settings JSON".
  • Close button text not centered in the integrity-violation dialog - the button has a MinWidth but no HorizontalContentAlignment, so a short label such as "Chiudi" sat left-aligned. It now centers its content, matching ImmersiveConfirmationDialog.

The three new keys are added to lang_en.json only; other locales will show English for them until translated (bovirus (@bovirus) asked to have the keys added so the Italian can follow).

Not in scope: the gendered-term point from the issue thread (e.g. "Enabled"/"Abilitato"/"Abilitata"), which needs per-context keys rather than a fix here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are narrowly scoped, follow established localization and layout patterns, and have no identified blocking issues.

No open issues 🎉

What changed in this PR

Addresses the remaining localization wiring and dialog alignment items from #5149 using existing UniGetUI translation mechanisms. The three new English keys enable future translations; other locales remain unchanged.

Changes:

  • Localizes view-mode tooltips, accessibility names, and settings JSON file-filter labels.
  • Adds English keys for both settings search prompts and the JSON filter label.
  • Centers the integrity-violation dialog’s Close button text.
File Description
src/​UniGetUI.Avalonia/​Views/​SoftwarePages/​AbstractPackagesPage.axaml Translates List, Grid, and Icons tooltips and accessibility names.
src/​UniGetUI.Avalonia/​Views/​DialogPages/​IntegrityViolationDialog.axaml Centers the Close button’s content.
src/​UniGetUI.Avalonia/​ViewModels/​Pages/​SettingsPages/​GeneralViewModel.cs Translates import/export file-filter labels.
src/​Languages/​lang_en.json Adds three missing translation keys.

Review effort: Balanced

@randy-but-a-ro randy-but-a-ro Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉

Integration Details
{
	"deliveryId": "722ed150-cf20-11f1-93a5-d81e0205ba16",
	"headSha": "d0dca39b4ac103f267708a1053774c357c187636",
	"reviewer": "copilot-pull-request-reviewer[bot]"
}

@GabrielDuf
Gabriel Dufresne (GabrielDuf) merged commit 59a8c89 into main Oct 23, 2026
7 checks passed
@GabrielDuf
Gabriel Dufresne (GabrielDuf) deleted the fix/5149-untranslated-strings branch October 23, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Strings not translated

2 participants