Repository navigation
Stop the Software Catalog loading bar's clock when hidden - #5592
Merged
Gabriel Dufresne (GabrielDuf) merged 1 commit intoOct 23, 2026
Merged
Conversation
The Software Catalog page declared its loading ProgressBar with a static IsIndeterminate="True" and hid it through IsVisible. An indeterminate ProgressBar's animation clock keeps ticking while the control is hidden, so the compositor keeps producing frames at the display refresh rate. The page is created lazily and then cached, so after the first visit to Software Catalog the idle GPU drain fixed in #5061 came back. Bind IsIndeterminate to IsLoading, the same flag that drives its visibility, matching how #5061 fixed every other indeterminate bar. Fixes #5058
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The single binding change uses the existing observable loading state and introduces no identified blocking issues.
No open issues 🎉
What changed in this PR
Stops the Software Catalog loading animation when loading finishes, extending the idle GPU usage fix from #5061 to the cached catalog page.
Changes:
- Binds
IsIndeterminatetoIsLoading, matching the progress bar’s visibility. - Leaves loading logic and rendering during active operations unchanged.
| File | Description |
|---|---|
src/UniGetUI.Avalonia/Views/SoftwarePages/SoftwareCatalogPage.axaml |
Replaces the always-running progress animation with a loading-state binding. |
Review effort: Balanced
There was a problem hiding this comment.
🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉
Integration Details
{
"deliveryId": "5a56d820-cf20-11f1-9acb-f81f9582bbe0",
"headSha": "91b689284d59f1d01eee3862b9d979628544fb3d",
"reviewer": "copilot-pull-request-reviewer[bot]"
}
Gabriel Dufresne (GabrielDuf)
deleted the
fix/5058-catalog-progressbar-gpu
branch
October 23, 2026 20:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Software Catalog page declared its loading
ProgressBarwith a staticIsIndeterminate="True"and hid it throughIsVisible. An indeterminateProgressBar's animation clock keeps ticking while the control is hidden, so the compositor keeps producing frames at the display refresh rate. The page is created lazily and then cached, so after the first visit to Software Catalog the idle GPU drain fixed in #5061 came back.This binds
IsIndeterminatetoIsLoading, the same flag that drives its visibility, matching how #5061 fixed every other indeterminate bar. It was the last staticIsIndeterminate="True"in the app.GPU usage while a reload or install is running is not addressed here: it comes from Avalonia's Windows renderer presenting the full window surface every frame, and is tracked upstream (AvaloniaUI/Avalonia#20757).
Fixes #5058