Repository navigation
Commit 8aae105
authored
chore(ci): fix CI warnings (#419)
Stacked on #418. Fixes the warnings reported by [CI run
38927727942](https://github.com/Devolutions/devolutions-crypto/actions/runs/38927727942).
## Fixed
- **Node 20 deprecation (actions)**: `download-artifact` v4 → v8,
`upload-artifact` v4/v4.3.6 → v7, `setup-python` v5 → v7, `setup-node`
v4 → v7, `setup-java` v3 → v6 (also clears the "setup-java v3 is
deprecated" warning). Uploads that were pinned to v4.3.6 get
`include-hidden-files: true` to keep the dotfile behaviour (v4.4+
excludes them by default). Artifacts are still zipped, so `dv github
download-artifact` in the release workflows is unaffected.
- **Cargo manifest**: drop `package.homepage` (redundant with
`package.repository`; printed on every cargo invocation). Add
`description`/`license`/`repository` to the `python` and
`devolutions-crypto-uniffi` crates (maturin's `cargo package --list`
warning).
- **cargo-deny yanked crate**: `chacha20` 0.10.1 → 0.10.2 (0.10.1 is
yanked). The lockfile diff touches only `chacha20`.
- **C# nullable warnings**:
- CS8632 in `dotnet-core`: enable `<Nullable>` (the shared test files
are annotated).
- CS8602/CS8604 in `android`: bump MSTest 3.0.0 → 3.7.1, matching the
local test project. MSTest 3.0.0 lacks `[NotNull]` on
`Assert.IsNotNull`; reproduced locally (42 warnings with 3.0.0, 0 with
3.7.1).
- CS8765 in iOS: `AppDelegate.FinishedLaunching` takes `NSDictionary?`.
- **NETSDK1202**: android nuget tests `net9.0-android` →
`net10.0-android` (CI already uses SDK 10). This is a separate commit,
so it's easy to drop if needed.
- **Kotlin Gradle deprecations**: `kotlinOptions` → `compilerOptions`;
library `targetSdk` moved to `testOptions`/`lint`.
## Not fixed (out of this repo's control)
- `uniffi.toml` "old-style --config": maturin passes the crate's
`uniffi.toml` to uniffi-bindgen 0.32 via `--config`. Python doesn't use
the `[bindings.kotlin]` section, and rewriting the file risks the Kotlin
package name.
- `zip v2.4.2` yanked, `buf_redux`/`multipart` future-incompat: these
come from the wasm-pack / wasm-bindgen-cli lockfiles installed with
`--locked`.
- emcc `WASM_BIGINT is deprecated`: injected by rustc's
`wasm32-unknown-emscripten` target, not by our flags.
- cargo-deny duplicate crates (`rand`, `getrandom`, `syn`, …): this
needs dependency-tree work and is out of scope.
- Homebrew "Skipping X / Treating azure-cli as a formula": these come
from re-running the Homebrew installer on the macOS runner.
- Runner notices (macOS arm64 capacity, `ubuntu-latest` → Ubuntu 26
migration) and the wasm-pack PATH hint.
## Verification
- `cargo test --lib`: 46 passed. `cargo package --list` no longer prints
manifest warnings.
- The local C# test project and the `dotnet-core` test project (built
against the source project) both build with 0 warnings.
- The `kotlin-android` lib builds with the new DSL
(`:lib:compileReleaseKotlin`).
- Android/iOS builds and the action bumps are verified by this PR's CI.1 parent d678c09 commit 8aae105
33 files changed
Lines changed: 83 additions & 58 deletions
File tree
- .github/workflows
- formatting
- csharp
- rust
- kotlin
- kotlin-linux
- kotlin-macos
- kotlin-windows
- native
- native-build-ios
- native-build-linux
- native-build-macos
- native-build-windows
- nugets/nugets-windows
- other
- source-publish
- webassembly-build
- python/build
- linux
- macos
- windows
- swift
- tests
- csharp
- android
- ios
- linux
- macos
- windows
- fuzz/quick
- python
- linux
- macos
- windows
- python
- uniffi/devolutions-crypto-uniffi
- wrappers
- csharp/tests/unit-tests/nugets
- android
- dotnet-core
- iOS
- kotlin-android/lib
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
134 | | - | |
| 134 | + | |
135 | 135 | | |
| 136 | + | |
136 | 137 | | |
137 | 138 | | |
138 | 139 | | |
139 | 140 | | |
140 | | - | |
| 141 | + | |
141 | 142 | | |
| 143 | + | |
142 | 144 | | |
143 | 145 | | |
144 | 146 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
| 40 | + | |
40 | 41 | | |
41 | 42 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
| 39 | + | |
39 | 40 | | |
40 | 41 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
| 118 | + | |
119 | 119 | | |
| 120 | + | |
120 | 121 | | |
121 | 122 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
159 | | - | |
| 159 | + | |
160 | 160 | | |
| 161 | + | |
161 | 162 | | |
162 | 163 | | |
163 | 164 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
| 73 | + | |
73 | 74 | | |
74 | 75 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
56 | 56 | | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
| 48 | + | |
48 | 49 | | |
49 | 50 | | |
0 commit comments