Skip to content

Commit 8aae105

Browse files
chore(ci): fix CI warnings (#419)
Stacked on #418. Fixes the warnings reported by [CI run 38927727942](https://github.com/Devolutions/devolutions-crypto/actions/runs/38927727942). ## Fixed - **Node 20 deprecation (actions)**: `download-artifact` v4 → v8, `upload-artifact` v4/v4.3.6 → v7, `setup-python` v5 → v7, `setup-node` v4 → v7, `setup-java` v3 → v6 (also clears the "setup-java v3 is deprecated" warning). Uploads that were pinned to v4.3.6 get `include-hidden-files: true` to keep the dotfile behaviour (v4.4+ excludes them by default). Artifacts are still zipped, so `dv github download-artifact` in the release workflows is unaffected. - **Cargo manifest**: drop `package.homepage` (redundant with `package.repository`; printed on every cargo invocation). Add `description`/`license`/`repository` to the `python` and `devolutions-crypto-uniffi` crates (maturin's `cargo package --list` warning). - **cargo-deny yanked crate**: `chacha20` 0.10.1 → 0.10.2 (0.10.1 is yanked). The lockfile diff touches only `chacha20`. - **C# nullable warnings**: - CS8632 in `dotnet-core`: enable `<Nullable>` (the shared test files are annotated). - CS8602/CS8604 in `android`: bump MSTest 3.0.0 → 3.7.1, matching the local test project. MSTest 3.0.0 lacks `[NotNull]` on `Assert.IsNotNull`; reproduced locally (42 warnings with 3.0.0, 0 with 3.7.1). - CS8765 in iOS: `AppDelegate.FinishedLaunching` takes `NSDictionary?`. - **NETSDK1202**: android nuget tests `net9.0-android` → `net10.0-android` (CI already uses SDK 10). This is a separate commit, so it's easy to drop if needed. - **Kotlin Gradle deprecations**: `kotlinOptions` → `compilerOptions`; library `targetSdk` moved to `testOptions`/`lint`. ## Not fixed (out of this repo's control) - `uniffi.toml` "old-style --config": maturin passes the crate's `uniffi.toml` to uniffi-bindgen 0.32 via `--config`. Python doesn't use the `[bindings.kotlin]` section, and rewriting the file risks the Kotlin package name. - `zip v2.4.2` yanked, `buf_redux`/`multipart` future-incompat: these come from the wasm-pack / wasm-bindgen-cli lockfiles installed with `--locked`. - emcc `WASM_BIGINT is deprecated`: injected by rustc's `wasm32-unknown-emscripten` target, not by our flags. - cargo-deny duplicate crates (`rand`, `getrandom`, `syn`, …): this needs dependency-tree work and is out of scope. - Homebrew "Skipping X / Treating azure-cli as a formula": these come from re-running the Homebrew installer on the macOS runner. - Runner notices (macOS arm64 capacity, `ubuntu-latest` → Ubuntu 26 migration) and the wasm-pack PATH hint. ## Verification - `cargo test --lib`: 46 passed. `cargo package --list` no longer prints manifest warnings. - The local C# test project and the `dotnet-core` test project (built against the source project) both build with 0 warnings. - The `kotlin-android` lib builds with the new DSL (`:lib:compileReleaseKotlin`). - Android/iOS builds and the action bumps are verified by this PR's CI.
1 parent d678c09 commit 8aae105

33 files changed

Lines changed: 83 additions & 58 deletions

File tree

‎.github/workflows/formatting/csharp/action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ runs:
44
using: composite
55
steps:
66
- name: Download Config
7-
uses: actions/download-artifact@v4
7+
uses: actions/download-artifact@v8
88
with:
99
name: config.txt
1010
path: ./wrappers/csharp

‎.github/workflows/formatting/rust/action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: Ensure that the Rust code format is compliant
33
runs:
44
using: composite
55
steps:
6-
- uses: actions/setup-python@v5
6+
- uses: actions/setup-python@v7
77
with:
88
python-version: "3.7"
99

‎.github/workflows/kotlin/kotlin-linux/action.yml‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ runs:
44
using: composite
55
steps:
66
- name: Download Version File
7-
uses: actions/download-artifact@v4
7+
uses: actions/download-artifact@v8
88
with:
99
name: config.txt
1010

1111
- name: Set up JDK 17
12-
uses: actions/setup-java@v3
12+
uses: actions/setup-java@v6
1313
with:
1414
distribution: 'temurin'
1515
java-version: '17'
@@ -22,7 +22,7 @@ runs:
2222
echo "version=$version" >> $GITHUB_OUTPUT
2323
2424
- name: Download Native Libs
25-
uses: actions/download-artifact@v4
25+
uses: actions/download-artifact@v8
2626
with:
2727
pattern: kotlin-*
2828
merge-multiple: true
@@ -131,14 +131,16 @@ runs:
131131
132132
133133
- name: Upload Kotlin JVM package
134-
uses: actions/upload-artifact@v4.3.6
134+
uses: actions/upload-artifact@v7
135135
with:
136+
include-hidden-files: true
136137
name: kotlin-jvm
137138
path: ./wrappers/kotlin/lib/build
138139

139140
- name: Upload Kotlin Android package
140-
uses: actions/upload-artifact@v4.3.6
141+
uses: actions/upload-artifact@v7
141142
with:
143+
include-hidden-files: true
142144
name: kotlin-android
143145
path: ./wrappers/kotlin-android/lib/build
144146

‎.github/workflows/kotlin/kotlin-macos/action.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ runs:
44
using: composite
55
steps:
66
- name: Download Version File
7-
uses: actions/download-artifact@v4
7+
uses: actions/download-artifact@v8
88
with:
99
name: config.txt
1010

@@ -35,7 +35,8 @@ runs:
3535
./gradlew generatePomFileForMavenPublication
3636
3737
- name: Upload Kotlin package
38-
uses: actions/upload-artifact@v4.3.6
38+
uses: actions/upload-artifact@v7
3939
with:
40+
include-hidden-files: true
4041
name: kotlin-macos
4142
path: ./wrappers/kotlin/lib/src/main/resources/

‎.github/workflows/kotlin/kotlin-windows/action.yml‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ runs:
44
using: composite
55
steps:
66
- name: Download Version File
7-
uses: actions/download-artifact@v4
7+
uses: actions/download-artifact@v8
88
with:
99
name: config.txt
1010

1111
- name: Set up JDK 17
12-
uses: actions/setup-java@v3
12+
uses: actions/setup-java@v6
1313
with:
1414
distribution: 'temurin'
1515
java-version: '17'
@@ -34,7 +34,8 @@ runs:
3434
3535
3636
- name: Upload Kotlin package
37-
uses: actions/upload-artifact@v4.3.6
37+
uses: actions/upload-artifact@v7
3838
with:
39+
include-hidden-files: true
3940
name: kotlin-windows
4041
path: ./wrappers/kotlin/lib/src/main/resources/

‎.github/workflows/native/native-build-ios/action.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ runs:
44
using: composite
55
steps:
66
- name: Download Config
7-
uses: actions/download-artifact@v4
7+
uses: actions/download-artifact@v8
88
with:
99
name: config.txt
1010
path: ./wrappers/csharp
@@ -115,7 +115,8 @@ runs:
115115
mkdir -p ./ios/ios
116116
cp -R ./tmp/ios/. ./ios/ios
117117
118-
- uses: actions/upload-artifact@v4.3.6
118+
- uses: actions/upload-artifact@v7
119119
with:
120+
include-hidden-files: true
120121
name: native-ios
121122
path: ./wrappers/csharp/ios

‎.github/workflows/native/native-build-linux/action.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ runs:
44
using: composite
55
steps:
66
- name: Download Config
7-
uses: actions/download-artifact@v4
7+
uses: actions/download-artifact@v8
88
with:
99
name: config.txt
1010
path: ./wrappers/csharp
@@ -156,8 +156,9 @@ runs:
156156
157157
dotnet build ./src/devolutions-crypto.csproj --framework netstandard2.0 -p:DefineConstants=BROWSER -p:Version="$VERSION_MANAGED" --configuration Release --output ./browser-wasm/bin
158158
159-
- uses: actions/upload-artifact@v4.3.6
159+
- uses: actions/upload-artifact@v7
160160
with:
161+
include-hidden-files: true
161162
name: native-android-linux
162163
path: |
163164
wrappers/csharp/android/**

‎.github/workflows/native/native-build-macos/action.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ runs:
44
using: composite
55
steps:
66
- name: Download Config
7-
uses: actions/download-artifact@v4
7+
uses: actions/download-artifact@v8
88
with:
99
name: config.txt
1010
path: ./wrappers/csharp
@@ -68,7 +68,8 @@ runs:
6868
mv wrappers/csharp/macos-temp/* wrappers/csharp/macos/macos/
6969
rmdir wrappers/csharp/macos-temp
7070
71-
- uses: actions/upload-artifact@v4.3.6
71+
- uses: actions/upload-artifact@v7
7272
with:
73+
include-hidden-files: true
7374
name: native-macos
7475
path: wrappers/csharp/macos/

‎.github/workflows/native/native-build-windows/action.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ runs:
44
using: composite
55
steps:
66
- name: Download Config
7-
uses: actions/download-artifact@v4
7+
uses: actions/download-artifact@v8
88
with:
99
name: config.txt
1010
path: ./wrappers/csharp
@@ -52,8 +52,9 @@ runs:
5252
dotnet build ./src/devolutions-crypto.csproj --framework netstandard2.0 -p:Version="$VERSION_MANAGED" --configuration Release --output ./dotnet-core/bin
5353
dotnet build ./src/devolutions-crypto.csproj --framework net48 -p:Version="$VERSION_MANAGED" --configuration Release --output ./dotnet-framework/bin
5454
55-
- uses: actions/upload-artifact@v4.3.6
55+
- uses: actions/upload-artifact@v7
5656
with:
57+
include-hidden-files: true
5758
name: native-windows
5859
path: |
5960
wrappers/csharp/windows/**

‎.github/workflows/nugets/nugets-windows/action.yml‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@ runs:
44
using: composite
55
steps:
66
- name: Download Config
7-
uses: actions/download-artifact@v4
7+
uses: actions/download-artifact@v8
88
with:
99
name: config.txt
1010
path: ./wrappers/csharp
1111

12-
- uses: actions/setup-python@v5
12+
- uses: actions/setup-python@v7
1313
with:
1414
python-version: "3.7"
1515

1616
- name: Download Native Libs
17-
uses: actions/download-artifact@v4
17+
uses: actions/download-artifact@v8
1818
with:
1919
pattern: native-*
2020
merge-multiple: true
@@ -43,7 +43,8 @@ runs:
4343
shell: bash
4444
run: mv wrappers/csharp/nuget/dotnet-core/package/*.nupkg .
4545

46-
- uses: actions/upload-artifact@v4.3.6
46+
- uses: actions/upload-artifact@v7
4747
with:
48+
include-hidden-files: true
4849
name: nugets-windows
4950
path: ./*.nupkg

0 commit comments

Comments
 (0)