Repository navigation
Remove the Ghostty engine - #63
Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intoOct 28, 2026
Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit into
Marc-André Moreau (mamoreau-devolutions) merged 1 commit into
Conversation
The builtin engine already covers everything the optional Ghostty engine offered: Ghostty advertised only VT52 keyboard support, while builtin adds grapheme clusters, row rendition, DRCS, kitty keyboard, modifyOtherKeys, Win32 input, and Sixel/iTerm2/ConEmu/kitty images. libghostty-vt 1.4 also regressed Windows scrollback ingest about 6x (DiscardVirtualMemory on every recycled page), so upgrading it was not worth carrying. - Delete Devolutions.Terminal.Ghostty, its tests, native/ghostty and the build-ghostty workflow; stop shipping libghostty-vt and its notice in the MSIX, Linux, macOS and NuGet payloads. - Drop experimental.terminalEngine and the engine pickers. Settings files that still select "ghostty" load as builtin and keep the key untouched. - Native restore now only builds dt-pty-host for Unix RIDs; Windows builds skip it. The Zig pin (0.16.0) moves to native/zig.json and CI cache keys follow it. - The vt bench replaces the ghostty-vt control with an FNV-1a clock control; -Baseline gates on builtin/control. -RequireBeatGhostty and -GhosttyBench are removed. - Move the Ghostty comparison write-up to docs/history and update the docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Marc-André Moreau (mamoreau-devolutions)
requested a review
from a team
as a code owner
October 28, 2026 18:21
Marc-André Moreau (mamoreau-devolutions)
deployed
to
publish-dry-run
October 28, 2026 18:26 — with
GitHub Actions
Active
Marc-André Moreau (mamoreau-devolutions)
deployed
to
publish-dry-run
October 28, 2026 18:26 — with
GitHub Actions
Active
Marc-André Moreau (mamoreau-devolutions)
deployed
to
publish-dry-run
October 28, 2026 18:26 — with
GitHub Actions
Active
Marc-André Moreau (mamoreau-devolutions)
deployed
to
publish-dry-run
October 28, 2026 18:26 — with
GitHub Actions
Active
Marc-André Moreau (mamoreau-devolutions)
merged commit Oct 28, 2026
d5c29ed
into
master
54 checks passed
Marc-André Moreau (mamoreau-devolutions)
deleted the
claude/ghostty-1-4-upgrade-985c2c
branch
October 28, 2026 19:06
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the optional Ghostty (
libghostty-vt) terminal engine. The builtin engine is now the only engine.Why
Vt52Keyboard. Builtin advertises that plus grapheme clusters, row rendition, DRCS, kitty keyboard, modifyOtherKeys, Win32 input, and Sixel/iTerm2/ConEmu/kitty images (seedocs/parity-status.md). On all 13 vt benchmark workloads the two engines produced identical screens except onestyledrow, which is a builtin bug (a combining mark after a space is dropped) and is not fixed here.experimental.terminalEngine; builtin was the default.scrolling: 29 → 5 MB/s). The cause is upstream commit60b43068c("reclaim pooled and compressed page memory on Windows"), which callsDiscardVirtualMemoryon every recycled page. Disabling that one change brought 1.4 back to 35 MB/s.What changed
src/Devolutions.Terminal.Ghostty,tests/Devolutions.Terminal.Ghostty.Tests,native/ghostty,.github/workflows/build-ghostty.ymlanddocs/ghostty-engine.md.experimental.terminalEngine(global and per profile) and the two engine pickers in the settings editor. A settings file that still selects"ghostty"loads as builtin, and saving leaves the key untouched because saves are diff-based. Tests cover this.ghostty-vt.dll/libghostty-vt.so/.dylibandTHIRD-PARTY-NOTICES-GHOSTTY.txtare no longer shipped or checked in the MSIX, Linux, macOS or NuGet payloads.GHOSTTY_LIBRARYis gone frommacos/package.env.NativeLibraries.targetsandRestore-NativeLibraries.ps1now only builddt-pty-host, for Linux/macOS RIDs; Windows builds skip the restore step entirely. The Zig pin (unchanged at 0.16.0) moves tonative/zig.json.native/zig.jsonand are bumped tonative-v3, so old caches containing Ghostty sources and binaries aren't restored.vtsuite replaces theghostty-vt/ghosttytargets with acontroltarget. It runs FNV-1a over the same bytes, a serial loop whose speed follows the core clock, and-Baselinenow gates on builtin/control.-RequireBeatGhostty,-GhosttyBench,--no-gateand the screen-equivalence check are removed.docs/history/ghostty-comparison-benchmarks.md, with a shorter currentdocs/performance-benchmarks.mdin its place. README, AGENTS, CONTRIBUTING, NOTICE, parity-status, release, macOS and renderer docs are updated.Testing
dotnet build Devolutions.Terminal.slnx -c Releasegives 0 warnings and 0 errors.dotnet testpasses 3,170 tests with 11 skipped (Windows x64).Test-ConPtyPublishLayout.ps1,Test-MacOsLegalNotices.ps1andTest-PackageBuild.ps1pass locally.linux-x64restore downloads Zig 0.16.0 fromnative/zig.jsonand buildsdt-pty-host. Awin-x64restore is a no-op.-Baselinecomparison between two runs works. Absolute builtin speed moved −3.4% while builtin/control moved +2.1%, so the control absorbs machine drift.Reviewer notes
bash -n, PowerShell parser). This PR's CI is their first real run, andTest-MacOsPackagingMetadata.ps1needsplutil.ghostty-genas the source of the corpus shapes, and the corpus bytes are unchanged so saved baselines stay comparable.winterm-ghosttycomments refer to an unrelated prior-art project.🤖 Generated with Claude Code