fix(cursor-hooks): preserve similarly named user hooks (#1052)

* fix(cursor-hooks): only match ponytail hook paths

* test(cursor-hooks): preserve similarly named user hooks

* refactor(cursor-hooks): use bounded hook regex

* test(cursor-hooks): cover later lookalike argument

Author: LurigeLars

scripts/cursor-hooks.js

@@ -15,7 +15,7 @@ const { isShellSafe } = require('../hooks/ponytail-config');
 
 const ROOT = path.join(__dirname, '..');
 const TEMPLATE = path.join(ROOT, 'hooks', 'cursor-hooks.json');
-const PONYTAIL_HOOK = /ponytail-[\w-]+\.js/;
+const PONYTAIL_HOOK = /[\\/]hooks[\\/]ponytail-[\w-]+\.js(?=["'\s]|$)/;
 
 function isPonytailHook(entry) {
   return Boolean(entry && typeof entry.command === 'string' && PONYTAIL_HOOK.test(entry.command));

tests/cursor-hooks.test.js

@@ -19,6 +19,7 @@ const { spawnSync } = require('child_process');
 const root = path.join(__dirname, '..');
 const rootFwd = root.replace(/\\/g, '/');
 const TEMPLATE = 'hooks/cursor-hooks.json';
+const { isPonytailHook } = require('../scripts/cursor-hooks');
 
 // Keep host detection and config resolution deterministic whatever shell the
 // suite runs in (a Cursor hook env, a Codex shell, a machine-wide default mode).
@@ -106,6 +107,12 @@ test('cursor hooks template is a valid hooks.json with the two events that can i
   }
 });
 
+test('hook detection ignores later lookalike arguments after a real ponytail hook', () => {
+  assert.equal(isPonytailHook({
+    command: 'node "/opt/p/hooks/ponytail-activate.js" --log /tmp/hooks/ponytail-x/',
+  }), true);
+});
+
 test('isCursor is off outside a Cursor hook process', () => {
   const { isCursor } = require('../hooks/ponytail-runtime');
   assert.equal(isCursor, false);
@@ -231,6 +238,7 @@ test('installer merges into an existing ~/.cursor/hooks.json and leaves unrelate
     hooks: {
       sessionStart: [{ command: './hooks/their-session.sh' }],
       afterFileEdit: [{ command: './hooks/format.sh', matcher: 'Write' }],
+      stop: [{ command: 'node "./hooks/my-ponytail-logger.js"' }],
     },
   };
   fs.writeFileSync(file, JSON.stringify(theirs));
@@ -241,6 +249,7 @@ test('installer merges into an existing ~/.cursor/hooks.json and leaves unrelate
   let config = JSON.parse(fs.readFileSync(file, 'utf8'));
   assert.equal(config.version, 1);
   assert.deepEqual(config.hooks.afterFileEdit, theirs.hooks.afterFileEdit);
+  assert.deepEqual(config.hooks.stop, theirs.hooks.stop, 'similarly named user hook must survive install');
   assert.equal(config.hooks.sessionStart[0].command, './hooks/their-session.sh', 'their sessionStart hook stays first and intact');
   assert.equal(config.hooks.sessionStart.length, 2);
   assert.deepEqual(config.hooks.sessionStart[1], { command: `node "${rootFwd}/hooks/ponytail-activate.js"`, timeout: 5 });