fix(hooks): normalize a backslashed plugin root before loading hook scripts (#646) (#752)

Under WSL2 the host expands the plugin root with Windows separators
(\home\user\...). That string is not absolute on Linux, so node resolves
the hook relative to the current working directory and every session
start and every prompt dies with MODULE_NOT_FOUND before any ponytail
code runs.

Normalise the separators in the bash commands so the path reaching node
is a valid POSIX path. copilot-hooks.json keeps bash and powershell in
separate fields, so bash-only expansion is safe here; the shared
`command` field in claude-codex-hooks.json still has to run under
PowerShell and is left alone.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Dietrich Gebert <dietrichgebert@gmail.com>

Author: 3 people

hooks/claude-codex-hooks.json

@@ -6,7 +6,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "node -e \"require(require('node:path').join(process.env.CLAUDE_PLUGIN_ROOT, 'hooks/ponytail-activate.js'))\"",
+            "command": "node -e \"require(require('node:path').join(process.env.CLAUDE_PLUGIN_ROOT.replaceAll(String.fromCharCode(92), '/'), 'hooks/ponytail-activate.js'))\"",
             "timeout": 5,
             "statusMessage": "Loading ponytail mode..."
           }
@@ -18,7 +18,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "node -e \"require(require('node:path').join(process.env.CLAUDE_PLUGIN_ROOT, 'hooks/ponytail-subagent.js'))\"",
+            "command": "node -e \"require(require('node:path').join(process.env.CLAUDE_PLUGIN_ROOT.replaceAll(String.fromCharCode(92), '/'), 'hooks/ponytail-subagent.js'))\"",
             "timeout": 5,
             "statusMessage": "Loading ponytail mode..."
           }
@@ -30,7 +30,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "node -e \"require(require('node:path').join(process.env.CLAUDE_PLUGIN_ROOT, 'hooks/ponytail-mode-tracker.js'))\"",
+            "command": "node -e \"require(require('node:path').join(process.env.CLAUDE_PLUGIN_ROOT.replaceAll(String.fromCharCode(92), '/'), 'hooks/ponytail-mode-tracker.js'))\"",
             "timeout": 5,
             "statusMessage": "Tracking ponytail mode..."
           }

hooks/copilot-hooks.json

@@ -4,16 +4,16 @@
     "sessionStart": [
       {
         "type": "command",
-        "bash": "node -e \"require(require('node:path').join(process.env.PLUGIN_ROOT, 'hooks/ponytail-activate.js'))\" || exit 0",
-        "powershell": "if (Get-Command node -ErrorAction SilentlyContinue) { node -e \"require(require('node:path').join(process.env.PLUGIN_ROOT, 'hooks/ponytail-activate.js'))\" }",
+        "bash": "node -e \"require(require('node:path').join(process.env.PLUGIN_ROOT.replaceAll(String.fromCharCode(92), '/'), 'hooks/ponytail-activate.js'))\" || exit 0",
+        "powershell": "if (Get-Command node -ErrorAction SilentlyContinue) { node -e \"require(require('node:path').join(process.env.PLUGIN_ROOT.replaceAll(String.fromCharCode(92), '/'), 'hooks/ponytail-activate.js'))\" }",
         "timeoutSec": 5
       }
     ],
     "userPromptSubmitted": [
       {
         "type": "command",
-        "bash": "node -e \"require(require('node:path').join(process.env.PLUGIN_ROOT, 'hooks/ponytail-mode-tracker.js'))\" || exit 0",
-        "powershell": "if (Get-Command node -ErrorAction SilentlyContinue) { node -e \"require(require('node:path').join(process.env.PLUGIN_ROOT, 'hooks/ponytail-mode-tracker.js'))\" }",
+        "bash": "node -e \"require(require('node:path').join(process.env.PLUGIN_ROOT.replaceAll(String.fromCharCode(92), '/'), 'hooks/ponytail-mode-tracker.js'))\" || exit 0",
+        "powershell": "if (Get-Command node -ErrorAction SilentlyContinue) { node -e \"require(require('node:path').join(process.env.PLUGIN_ROOT.replaceAll(String.fromCharCode(92), '/'), 'hooks/ponytail-mode-tracker.js'))\" }",
         "timeoutSec": 5
       }
     ]

tests/hooks.test.js

@@ -80,22 +80,30 @@ let result;
 // The shared Claude/Codex command must stay guard-free: VS Code runs it in
 // Windows PowerShell, which cannot parse `||` (see hooks-windows.test.js), so
 // it only has to run clean with node.
+// WSL2 can hand hooks a backslashed root (\home\user\...); the commands turn it
+// back into a POSIX path, so both shapes must load the script (#646).
+const roots = [root, root.split(path.sep).join('\\')];
+
 for (const command of collectManifestCommands('hooks/claude-codex-hooks.json', 'command')) {
-  result = runShell(command, { ...process.env, HOME: home, USERPROFILE: home, CLAUDE_PLUGIN_ROOT: root });
-  assert.equal(result.status, 0, result.stderr);
-  assert.equal(result.stderr, '', command);
+  for (const pluginRoot of roots) {
+    result = runShell(command, { ...process.env, HOME: home, USERPROFILE: home, CLAUDE_PLUGIN_ROOT: pluginRoot });
+    assert.equal(result.status, 0, result.stderr);
+    assert.equal(result.stderr, '', command);
+  }
 }
 
 // Copilot CLI has a separate bash field, so it can exit 0 without node (#645).
 // `|| exit 0` also hides a broken hook, so the with-node run must leave stderr empty.
 for (const command of collectManifestCommands('hooks/copilot-hooks.json', 'bash')) {
-  const env = { HOME: home, USERPROFILE: home, PLUGIN_ROOT: root, COPILOT_PLUGIN_DATA: path.join(temp, 'copilot-manifest-data') };
-  result = runShell(command, { ...process.env, ...env });
-  assert.equal(result.status, 0, result.stderr);
-  assert.equal(result.stderr, '', command);
-
-  result = runShell(command, { ...env, PATH: '' });
-  assert.equal(result.status, 0, result.stderr);
+  for (const pluginRoot of roots) {
+    const env = { HOME: home, USERPROFILE: home, PLUGIN_ROOT: pluginRoot, COPILOT_PLUGIN_DATA: path.join(temp, 'copilot-manifest-data') };
+    result = runShell(command, { ...process.env, ...env });
+    assert.equal(result.status, 0, result.stderr);
+    assert.equal(result.stderr, '', command);
+
+    result = runShell(command, { ...env, PATH: '' });
+    assert.equal(result.status, 0, result.stderr);
+  }
 }
 
 // USERPROFILE alongside HOME: os.homedir() reads USERPROFILE on Windows, HOME on POSIX.