Repository navigation
fix(opencode): keep the one-shot review out of the mode flag - #1047
Closed
tangsong404 wants to merge 1 commit into
Closed
tangsong404 wants to merge 1 commit into
tangsong404 wants to merge 1 commit into
Conversation
`/ponytail review` was validated with `normalizePersistedMode`, so the argument was written to the long-lived `.ponytail-active` flag. Every later session then injected only the one-line `level: review` stub instead of the ruleset, until the user switched back to a real level. Review is a one-shot skill, never a persistent level (DietrichGebert#377, DietrichGebert#736), and every other host already rejects it as a command argument. Validate the command argument with `normalizeMode` (runtime levels only). Reading is unchanged: a stored `review` flag is still honored.
Owner
|
Thanks! #1103 fixes the same review problem and also resets a review that was already saved, so I'm going with that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/ponytail reviewwas validated withnormalizePersistedMode, so the argument was written to the long-lived.ponytail-activeflag. Every later session then injected only the one-linelevel: reviewstub instead of the ruleset, until the user switched back to a real level. Review is a one-shot skill, never a persistent level (#377, #736), and every other host already rejects it as a command argument.Validate the command argument with
normalizeMode(runtime levels only). Reading is unchanged: a storedreviewflag is still honored.