Repository navigation
fix(qoder): honor QODER_CONFIG_DIR for mode state - #1057
Merged
DietrichGebert merged 2 commits intoOct 13, 2026
Merged
DietrichGebert merged 2 commits into
DietrichGebert merged 2 commits into
Conversation
6639835
reviewed
Oct 8, 2026
6639835
left a comment
There was a problem hiding this comment.
Reviewed Qoder resolution across config, runtime state and uninstall at 764720f. The shared resolver honors QODER_CONFIG_DIR and preserves the default; reads, writes and uninstall derive from that location. Tests cover custom mode/subagent tracking and default/custom uninstall isolation. No actionable issue found in this static scope. Node hook/uninstall suites were not run.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honor Qoder's
QODER_CONFIG_DIRwhen Ponytail stores, reads, and removes its mode flag. This keeps mode switching and subagent injection in Qoder's selected user directory and lets uninstall clean the same flag.Problem and cause
With
QODER_SESSION_IDandQODER_CONFIG_DIR=<custom>set,/ponytail ultrawrites~/.qoder/.ponytail-active;<custom>/.ponytail-activeis absent. The runtime and uninstaller both hardcode~/.qodereven though Qoder supports the directory override. An isolated probe reproduced this onmainat552acd5. Fixes #1056.Changes
QODER_CONFIG_DIRwith the current~/.qoderfallback.Testing
<custom>flag missing; default flag written). New uninstall assertion on base: failed (custom flag remained).npm teston this HEAD (764720f) under Ubuntu/Node 22 with the repository's documented pandas dependency: passed (127 root tests and 28 Pi tests).node tests/uninstall.test.json Windows: passed.node scripts/check-rule-copies.js,node scripts/check-versions.js,git diff --check: passed.tests/hooks.test.jsstops at the pre-existing path assertion tracked by test: compare the statusline copy path JSON-escaped in hooks.test.js #1046 before reaching the new Qoder case; the Qoder hook tests passed under Ubuntu.No ruleset text changed, so the three-arm ruleset benchmark is not applicable under CONTRIBUTING.