Repository navigation
fix: preserve invalid Cursor hook configurations during install - #1059
Merged
DietrichGebert merged 2 commits intoOct 13, 2026
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1058.
The Cursor installer currently overwrites valid JSON with invalid hooks.json shapes: root/hooks arrays are discarded, and a string-valued event becomes an array of individual characters. Reject those shapes before merging, leaving the file unchanged and reporting the field to repair. Missing config files and missing hooks objects still initialize normally.
Three subprocess regressions fail before the fix and verify the original file remains byte-for-byte intact afterward.
npm testpasses all 130 root tests and 28 Pi tests.node scripts/check-rule-copies.jsandnode scripts/check-versions.jspass. Tests use isolated temporary homes; no real Cursor configuration was modified and no live Cursor/model session was run.Checked existing Cursor configuration issues/PRs, including #1052 (hook ownership matching); this addresses invalid configuration shapes separately. No ruleset or prompt changes.