Repository navigation
chore(hermes): drop the unreachable review mode - #1105
Merged
DietrichGebert merged 2 commits intoOct 13, 2026
Merged
DietrichGebert merged 2 commits into
DietrichGebert merged 2 commits into
Conversation
The Hermes plugin only ever builds context from `_current_mode` or the default, and both accept off/lite/full/ultra only, so the review branch, CONFIG_MODES, _normalize_config_mode and REVIEW_SKILL never ran outside a test. Removed them and the test that exercised only that code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks! Tested it in Hermes v0.21.7: normal turns and other levels inject the same as before, and /ponytail-review is unaffected. Merged, will be in the next release. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This removes
CONFIG_MODES,_normalize_config_mode,REVIEW_SKILLand the review branch ofbuild_injected_contextfrom__init__.py: -21 lines.Why
build_injected_contextis only called from_pre_llm_call, with_current_modeor_default_mode(). Both only produce off/lite/full/ultra, so the review branch never ran outside a test.Tests
Checks
npm test(all green on this branch alone),node scripts/check-rule-copies.js,node scripts/check-versions.js. No ruleset text changed, so no benchmark (CONTRIBUTING.md).🤖 Generated with Claude Code