Repository navigation
fix(hooks): write hook output synchronously so process.exit cannot drop it - #1112
Merged
Merged
Conversation
This was referenced Oct 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1043.
Every hook calls
process.exit()right afterwriteHookOutput(). On macOS a write to a pipe is asynchronous, so when the pipe cannot take the whole output at once, the rest is still pending when the process exits and is lost. The host then gets truncated or empty JSON and no ruleset.writeHookOutput()is the one place all hook output goes through. It now writes withfs.writeSync(1, ...), so the output is complete before any exit. All callers already wrap it intry/catch, so a closed reader (EPIPE) still never fails the hook.Checked on macOS with a pipe that is already full when the hook starts (the reader drains it only later):
/ponytail lite)A reader that closed the pipe: all three hooks exit 0 with no stderr.
npm testpasses (136 + 29).