Repository navigation
fix(debt): grep -- and ; comment markers too - #1117
Open
devohmycode wants to merge 1 commit into
Open
devohmycode wants to merge 1 commit into
devohmycode wants to merge 1 commit into
Conversation
This was referenced Oct 13, 2026
offendingcommit
added a commit
to offendingcommit/ponytail
that referenced
this pull request
Oct 13, 2026
Exercise SQL/Lua, HTML, and Lisp comment candidates for both neutral and legacy markers across all four debt entry points. Preserve explicit coverage alongside the open prefix-focused peer PR. Refs: DietrichGebert#1123 Refs: DietrichGebert#1117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
/ponytail-debtpattern only knows#,//and/*. Markers in--comments (SQL, Lua, Haskell, and HTML's<!--) and in;comments (INI, Lisp) never reach the ledger.Fix
The pattern adds
--and;, in all four copies. It sits on top of #1108; this is the part of #1076 that #1108 did not cover.Checks
tests/commands.test.jsfeeds--,<!--and;markers to the real pattern of each copy: 5/5 pass. The new samples fail on the old pattern.examples/modal-dialog.md, and nothing else new.node scripts/check-rule-copies.jsandnode scripts/check-versions.jspass.