Repository navigation
fix(pi): treat review as a command, never a session level - #1120
Open
CodeAlex52 wants to merge 1 commit into
Open
CodeAlex52 wants to merge 1 commit into
CodeAlex52 wants to merge 1 commit into
Conversation
A ponytail-mode entry saved by an older pi version still latched: review resolved as a session level, so every later turn injected the one-line pointer instead of the ruleset (the state DietrichGebert#736 removed from the hooks, DietrichGebert#1103 from OpenCode and DietrichGebert#1105 from Hermes). resolveSessionMode now skips a review entry and falls back, setMode refuses non-runtime values, and the fallback normalizations only accept runtime levels too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
resolveSessionModestill acceptedreviewas a session level, so aponytail-modeentry saved by an older pi version latched: every later turn injected the one-line pointer instead of the ruleset — the state #736 removed from the hooks, #1103 from OpenCode ("a review saved by an older version falls back to the default instead of latching") and #1105 from Hermes.Fix
pi now only honors runtime levels (off/lite/full/ultra):
resolveSessionModeskips areviewentry, keeps looking, then falls back to the default;setModerefuses non-runtime values;normalizeModetoo, so areviewfallback cannot latch either./ponytail-reviewis unaffected — it already runs as a one-shot skill alias, never as a mode.Tests
resolveSessionModedrops a review entry saved by an older version (/ponytail-review latches the session mode flag, replacing the ruleset with a pointer line for the rest of the session #736);npm testpasses (root suite and pi-extension).