Repository navigation
fix(pi-extension): guard status bar render when ui lacks a theme - #279
Merged
Merged
Conversation
syncStatus guarded setStatus but used theme.fg unguarded, so a Pi host exposing setStatus without a theme threw TypeError on session_start (and agent_start/agent_end/setMode). Require both before rendering. Add tests for the render path (previously untested) and the theme-absent degradation. Follow-up to #275 / #84.
Afristrat
pushed a commit
to Afristrat/ponytail
that referenced
this pull request
Sep 29, 2026
…richGebert#279) syncStatus guarded setStatus but used theme.fg unguarded, so a Pi host exposing setStatus without a theme threw TypeError on session_start (and agent_start/agent_end/setMode). Require both before rendering. Add tests for the render path (previously untested) and the theme-absent degradation. Follow-up to DietrichGebert#275 / DietrichGebert#84.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #275 (the status bar from #84).
syncStatusguardedsetStatusbut usedtheme.fgunguarded, so a Pi host that exposessetStatuswithout athemethrowsTypeError: Cannot read properties of undefined (reading 'fg')onsession_start(andagent_start/agent_end/setMode). Real Pi provides both, so it never fired there. This closes the gap the existingsetStatusguard already intended: the feature needs both, so lacking either it bails.index.js: requiresetStatusandtheme.fgbefore rendering.npm testgreen.