fix(letter): keep legal citations unbroken and give each follow-up it… - #209
Open
patrickuhlmann wants to merge 1 commit into
Open
fix(letter): keep legal citations unbroken and give each follow-up it…#209patrickuhlmann wants to merge 1 commit into
patrickuhlmann wants to merge 1 commit into
Conversation
…s own subject The dates and article references in the letters were written with normal spaces, so a line could break right after "31.", "25." or "Art.". Day, month and year as well as abbreviation, article number and law abbreviation are now joined with non-breaking spaces (U+00A0) in the German and French letter texts and in the component defaults. The follow-up letters for an incomplete answer, a correction and a deletion all carried the generic subject "Datenauskunftsbegehren". Each now has its own key, mirroring the existing "Ausbleibende Auskunft" letter: - letter_info_req_demand_subject — "Datenauskunftsbegehren / Unvollständige Auskunft" - letter_info_req_change_subject — "Datenauskunftsbegehren / Berichtigung" - letter_info_req_delete_subject — "Datenauskunftsbegehren / Löschung" The now unused keys data_access_request and data_disclosure_request were removed from both letter locale files. Playwright tests cover the protected citations in the initial, remind and demand letters (German and French) and the three new subject lines. Closes #195
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s own subject
The dates and article references in the letters were written with normal spaces, so a line could break right after "31.", "25." or "Art.". Day, month and year as well as abbreviation, article number and law abbreviation are now joined with non-breaking spaces (U+00A0) in the German and French letter texts and in the component defaults.
The follow-up letters for an incomplete answer, a correction and a deletion all carried the generic subject "Datenauskunftsbegehren". Each now has its own key, mirroring the existing "Ausbleibende Auskunft" letter:
The now unused keys data_access_request and data_disclosure_request were removed from both letter locale files.
Playwright tests cover the protected citations in the initial, remind and demand letters (German and French) and the three new subject lines.
Closes #195