Merge branch 'main' into test-skeleton/reports-specs

Author: DiogoRibeiro7

tests/test_events_loader.py

@@ -1,9 +1,108 @@
-import importlib
+from __future__ import annotations
 
+from datetime import datetime, timezone
+from pathlib import Path
 
-def test_import_events_loader():
-    mod = importlib.import_module("llm_observability_analytics.events.loader")
-    assert mod is not None
+import pytest
 
+from llm_observability_analytics.contracts.models import (
+    LLMInteractionEvent,
+    ModelExecutionContext,
+    TokenUsageRecord,
+    LatencyRecord,
+    SourceGroundingReference,
+    RetrievalTraceEvent,
+)
+from llm_observability_analytics.events.loader import (
+    load_interaction_events,
+    load_retrieval_trace_events,
+)
+
+
+def _now_iso() -> str:
+    return datetime.now(tz=timezone.utc).isoformat()
+
+
+def _make_interaction(query_id: str, trace_id: str) -> LLMInteractionEvent:
+    mc = ModelExecutionContext(
+        query_id=query_id,
+        trace_id=trace_id,
+        model_version="m-v",
+        dataset_version=None,
+        provider="prov",
+        model_name="name",
+    )
+    tu = TokenUsageRecord(
+        query_id=query_id,
+        trace_id=trace_id,
+        model_version="m-v",
+        dataset_version=None,
+        input_tokens=1,
+        output_tokens=2,
+        recorded_at=datetime.now(timezone.utc),
+    )
+    lat = LatencyRecord(
+        query_id=query_id,
+        trace_id=trace_id,
+        request_timestamp=datetime.now(timezone.utc),
+        response_timestamp=datetime.now(timezone.utc),
+        latency_ms=123,
+    )
+    ref = SourceGroundingReference(
+        query_id=query_id, trace_id=trace_id, document_id="doc1", chunk_id="chk1"
+    )
+    return LLMInteractionEvent(
+        query_id=query_id,
+        trace_id=trace_id,
+        request_timestamp=datetime.now(timezone.utc),
+        response_timestamp=datetime.now(timezone.utc),
+        prompt_text="p",
+        response_text="r",
+        model_context=mc,
+        token_usage=tu,
+        latency=lat,
+        retrieval_references=[ref],
+    )
+
+
+def _make_retrieval(query_id: str, trace_id: str) -> RetrievalTraceEvent:
+    ref = SourceGroundingReference(
+        query_id=query_id, trace_id=trace_id, document_id="doc1", chunk_id="chk1"
+    )
+    return RetrievalTraceEvent(
+        query_id=query_id,
+        trace_id=trace_id,
+        retrieval_timestamp=datetime.now(timezone.utc),
+        query_text="hello",
+        retrieval_system="r",
+        top_k=1,
+        references=[ref],
+    )
+
+
+def test_load_interaction_events_success(tmp_path: Path) -> None:
+    p = tmp_path / "interactions.jsonl"
+    evt = _make_interaction("q1", "t1")
+    p.write_text(evt.to_json() + "\n", encoding="utf-8")
+
+    out = load_interaction_events(p, max_events=10)
+    assert len(out) == 1
+    assert out[0].query_id == "q1"
+
+
+def test_load_retrieval_trace_events_success(tmp_path: Path) -> None:
+    p = tmp_path / "retrieval.jsonl"
+    evt = _make_retrieval("q2", "t2")
+    p.write_text(evt.to_json() + "\n", encoding="utf-8")
+
+    out = load_retrieval_trace_events(p, max_events=10)
+    assert len(out) == 1
+    assert out[0].query_id == "q2"
+
+
+def test_load_invalid_json_raises(tmp_path: Path) -> None:
+    p = tmp_path / "broken.jsonl"
+    p.write_text("{not-json}\n", encoding="utf-8")
+    with pytest.raises(ValueError):
+        load_interaction_events(p, max_events=10)
 
-# TODO: add file-based loader tests using tmp_path

tests/test_metrics_models.py

@@ -1,9 +1,35 @@
-import importlib
+from __future__ import annotations
 
+import json
+from dataclasses import asdict
 
-def test_import_metrics_models():
-    mod = importlib.import_module("llm_observability_analytics.metrics.models")
-    assert mod is not None
+from llm_observability_analytics.metrics.models import MetricRecord, AnalyticsSummary
 
 
-# TODO: add numeric helper tests with small sample inputs
+def test_metric_record_basic():
+    mr = MetricRecord(metric_name="latency", metric_value=12.5, dimension_key="service", dimension_value="svc-a")
+    assert mr.metric_name == "latency"
+    assert mr.metric_value == 12.5
+
+
+def test_analytics_summary_roundtrip():
+    s = AnalyticsSummary(
+        request_count=10,
+        retrieval_trace_count=4,
+        latency_mean_ms=100.0,
+        latency_p50_ms=90.0,
+        latency_p95_ms=150.0,
+        total_tokens=1234,
+        average_tokens_per_request=123.4,
+        retrieval_hit_count=3,
+        grounded_response_count=7,
+        ungrounded_response_count=3,
+        feedback_count=2,
+    )
+    d = s.to_dict()
+    assert d["request_count"] == 10
+    # JSON roundtrip
+    j = s.to_json()
+    parsed = json.loads(j)
+    assert parsed == asdict(s)
+