Conversation
|
💡 Tip: Link this PR to an issue! We noticed this PR doesn't link to any issue. Linking helps us:
How to link:
No related issue?
Thanks for contributing! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Description
Fixes a bug in filament entity picture generation when Spoolman returns multi-color hex values with an alpha channel, for example
FF6A13FF.Previously, multi-color values were only handled correctly when each hex color was 6 characters long. As a result, some valid multi-color filaments could fail to render their entity picture correctly when 8-character hex values were present.
This change keeps the multi-color values intact so Home Assistant can generate the filament picture without rejecting alpha-enabled colors.
🔗 Related Issue
No related issue.
This change is needed because some Spoolman setups return 8-character hex colors for multi-color filaments, which caused broken image generation in the integration.
🎨 Type of Change
🧪 Testing
Test Environment
Test Scenarios
multi_color_hexescontaining standard 6-character values.multi_color_hexescontaining 8-character values with alpha, such asFF6A13FF.📸 Screenshots/Videos
Not applicable.
✅ Checklist
devbranch (notmain)manifest.jsonif needed📋 Commit Message Format
Example commit message used for this change:
fix: support alpha-enabled multi-color filament hex values🚀 Migration Notes
Not applicable.
📝 Additional Notes
This is a focused bug fix and does not change the public configuration or entity model.
🙏 Acknowledgments
Thanks to the maintainers for reviewing.