Repository navigation
For defense-in-depth only allow primitive types to be unserialize()-d - #1700
Merged
Merged
Conversation
Out of an abundance of caution in case there is some path by which user-provided serialized data can be provided to the project search filters. If that were to happen, it would likely be an exploitable security hole.
As far as I can tell, only validated user input (arrays of forum posting ID integers) is serialized into the DB, but out of an abundance of caution, only allow primitive types to be deserialized to avoid PHP unserialize() security issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.