Repository navigation
Conversation
mysqli_result objects, like all PHP values, are reference counted. When they are overwritten (eg when assigned to in a loop), or when they go out of scope (eg at the end of a block/function), the refcount is decremented, and the object freed when the refcount reaches zero. Thus we can remove mysqli_free_result when it occurs close to the end of a block/function, because it only shortens the lifetime of a result by a tiny amount and clutters up the code for negligible benefit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mysqli_result objects, like all PHP values, are reference counted. When they are overwritten (eg when assigned to in a loop), or when they go out of scope (eg at the end of a block/function), the refcount is decremented, and the object freed when the refcount reaches zero.
Thus we can remove mysqli_free_result when it occurs close to the end of a block/function, because it only shortens the lifetime of a result by a tiny amount and clutters up the code for negligible benefit.