NEW PODMAN_BUILD=1 option to update.sh - #111
Conversation
| fi | ||
|
|
||
| if [ "${PODMAN_BUILD}" = "1" ]; then | ||
| echo "Trying to build ${buildOptionTags} in '${dir}'" |
There was a problem hiding this comment.
Looks good to me, can you just remove the debug output to stay consistent with the docker build step?
Another implementation idea would be to add a "CONTAINER_CMD" variable for example that will default to "docker". And since podman use the same convention as docker it would be a drop in replacement :
CONTAINER_CMD={$CONTAINER_CMD:docker}
// later on...
$CONTAINER_CMD build \
--compress \
${buildOptionTags} \
"${dir}"The only thing that won't 100% work is everything related to "buildx". But in this case we can just keep the hardcoded "docker" call.
wdyt?
There was a problem hiding this comment.
my immediate thought is that that buildx and podman would make some issues, so I'm more inclined to keep it as a separate build option - at least for now, also since I expect very few people to use it, and I want as few people as possible getting issues with podman which they might not even know what is
There was a problem hiding this comment.
Looks good to me! Can you just remove the print output to stay consistent with the docker build?
2 participants
NEW PODMAN_BUILD=1 option to update.sh
Applying this PR will add a PODMAN_BUILD option to update.sh just like the DOCKER_BUILD option.
tested like this
PODMAN_BUILD=1 ./update.shResults