Skip to content

docs: architecture review, ADR acceptance, cross-GDD reconciliation, test scaffolding - #127

Open
Mlucana wants to merge 1 commit into
Donchitos:mainfrom
Mlucana:design/architecture-review-and-reconciliation
Open

Mlucana wants to merge 1 commit into
Donchitos:mainfrom
Mlucana:design/architecture-review-and-reconciliation

Conversation

@Mlucana

@Mlucana Mlucana commented Sep 1, 2026

Copy link
Copy Markdown

Checkpoint of the pre-production design + architecture pass for "What the Gods Left Behind". First push of the full game-design corpus plus the architecture-decision layer and test infrastructure.

Architecture

  • /architecture-review 2026-08-21 (CONCERNS) — review report, traceability index, and tr-registry.yaml populated with 399 stable TR-IDs.
  • ADR-0001 (instance combat-stat modifier layer) and ADR-0002 (TimeControl) moved Proposed → Accepted with engine-audit cleanups; architecture.yaml stances wired.
  • ADR-0003 (Save/Persistence) and ADR-0004 (Era lifecycle / EraManager) added by the parallel workstream — still Proposed, reconciliation pending.

Cross-GDD reconciliation (closes cross-review 2026-08-18 blockers)

  • F2-B1 effective_attack_damage → ADR-0001 · F2-B4/S2 offering_time_scale → ADR-0002
  • F2-B3/B7 Reliquias reciprocal wiring · F2-B6 systems-index dependency map · F2-W3 Furia exception in Combate Regla 5
  • F2-B5 band cap: max_band_size authored in EraDefinition (Tropas Fórmula E), two independent faucets; entities.yaml constant registered
  • S1 Regla 10 origin_era_id pool filter made implementable and consistent
  • S7/OQ-15 (Furia freeze scope + sacrifice loophole) verified resolved
  • Only S4/persistence remains, in flight as ADR-0003

Test infrastructure (/test-setup, Godot 4.6 / GdUnit4)

  • tests/ layout, gdunit4_runner.gd, smoke critical-paths, self-contained example unit test (CI green day one)
  • .github/workflows/tests.yml CI · framework corrected GUT → GdUnit4

Also

  • CLAUDE.md engine (Godot 4.6 / GDScript), .gitignore session-state/, agent-memory, consistency reports.

⚠️ Note: this is a large pre-production checkpoint (first commit of the design corpus). ADR-0003/0004 are work-in-progress (Proposed). Opened from fork Mlucana/Claude-Code-Game-Studios.

🤖 Generated with Claude Code

…test scaffolding

Checkpoint of the pre-production design + architecture pass. First commit of the
full game design corpus for "What the Gods Left Behind" plus the architecture
decision layer and test infrastructure.

Architecture:
- /architecture-review 2026-08-21 (CONCERNS): review report, traceability index,
  tr-registry.yaml populated with 399 stable TR-IDs.
- ADR-0001 (instance combat-stat modifier layer) and ADR-0002 (TimeControl) moved
  Proposed->Accepted with engine-audit cleanups; architecture.yaml stances wired.
- ADR-0003 (Save/Persistence) and ADR-0004 (Era lifecycle/EraManager) added by the
  parallel workstream — still Proposed, reconciliation pending.

Cross-GDD reconciliation (closes cross-review 2026-08-18 blockers):
- F2-B1 effective_attack_damage (ADR-0001), F2-B4/S2 offering_time_scale (ADR-0002),
  F2-B3/B7 Reliquias reciprocal wiring, F2-B6 systems-index dependency map,
  F2-W3 Furia exception in Combate Regla 5.
- F2-B5 band cap: max_band_size authored in EraDefinition (Tropas Formula E), two
  independent faucets; entities.yaml constant registered.
- S1 Regla 10 origin_era_id pool filter made implementable and consistent.
- S7/OQ-15 (Furia freeze scope + sacrifice loophole) verified resolved.
- Only S4/persistence remains, in flight as ADR-0003.

Test infrastructure (/test-setup, Godot 4.6 / GdUnit4):
- tests/ layout, gdunit4_runner.gd, smoke critical-paths, self-contained example
  unit test; .github/workflows/tests.yml CI. Framework corrected GUT->GdUnit4.

Also: CLAUDE.md engine (Godot 4.6/GDScript), gitignore session-state/, agent-memory.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Mlucana
Mlucana requested a review from Donchitos as a code owner September 1, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant