Say what the update bar is and how far its download has got - #2021
Open
mehranlatifi83 wants to merge 1 commit into
Open
Say what the update bar is and how far its download has got#2021mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
|
@DrKLO The build currently fails during Gradle sync because the jlatexmath module is not included in the root settings.gradle. Please add: include ':jlatexmath'
project(':jlatexmath').projectDir = file('TMessagesProj/lib/jlatexmath/jlatexmath') |
A new version announces itself with a dialog that reads well enough, and pressing update on it leaves a bar at the bottom of the main screen. That bar is the only way to follow the download, to stop it, and to install what came down, and a screen reader has nothing to say about it: the text it shows is drawn rather than laid out, the size beside it is drawn by something that is not a view at all, and so is the icon that carries its state. Have the bar say what it draws. It reports as the button it is, it says the text it shows along with the size of what is to be downloaded, and the label of its click action says what pressing it does at that moment, which is downloading, stopping, or installing, all of which its icon is alone in telling everyone else. The text it holds is left out of what is read, so the bar is one stop rather than two.
mehranlatifi83
force-pushed
the
fix/talkback-update-bar-without-label
branch
from
August 29, 2026 19:07
d4494aa to
92a7c3a
Compare
Author
|
Hi @pfeux — this is about the repository's own |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A new version announces itself with a dialog that reads well enough, and pressing update on it leaves a bar at the bottom of the main screen. That bar is the only way to follow the download, to stop it, and to install what came down, and a screen reader has nothing to say about it: the text it shows is drawn rather than laid out, the size beside it is drawn by something that is not a view at all, and so is the icon that carries its state.
Have the bar say what it draws. It reports as the button it is, it says the text it shows along with the size of what is to be downloaded, and the label of its click action says what pressing it does at that moment, which is downloading, stopping, or installing, all of which its icon is alone in telling everyone else. The text it holds is left out of what is read, so the bar is one stop rather than two.
Both builds that carry an update bar of their own are covered.
Checking it
With TalkBack on, take an in-app update and press update on the dialog, which leaves a bar at the bottom of the main screen.
Before, that bar said nothing at all: not what it was, not the size of what was coming down, not how far it had got. Now it reports as the button it is, says its text and the size beside it, and its action says what pressing it does at that moment, which is downloading, stopping or installing.