Give a video and a piece of music a download of their own - #2041
Open
mehranlatifi83 wants to merge 1 commit into
Open
Give a video and a piece of music a download of their own#2041mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
A video and a piece of music are the two worth having on the phone before they are wanted, and the two whose downloads run long enough to be worth stopping. Neither could be asked for on its own. Pressing the message is all there was, and pressing it does something else: it opens the viewer, and streams what has not arrived, or it starts playing. Keeping the file was only ever a side effect of watching or listening to it, and stopping the download was reachable only in the states where pressing the message happened to mean cancel. Both are now an action of their own, on a video and on a piece of music that is not already on the phone. While the file is on its way the action cancels it; where it was never started, or was stopped part of the way through, the action fetches it, and only fetches it: nothing is opened and nothing is played. A download taken up again carries on from where it was stopped, as it does for the button that is drawn. The action is not offered for what is already here, nor for a message still on its way out.
mehranlatifi83
force-pushed
the
fix/talkback-no-download-action-for-media
branch
from
August 30, 2026 09:45
6036541 to
bcd63a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A video and a piece of music are the two worth having on the phone before
they are wanted, and the two whose downloads run long enough to be worth
stopping. Neither could be asked for on its own.
Pressing the message is all there was, and pressing it does something
else: it opens the viewer, and streams what has not arrived, or it starts
playing. Keeping the file was only ever a side effect of watching or
listening to it, and stopping the download was reachable only in the
states where pressing the message happened to mean cancel.
Both are now an action of their own, on a video and on a piece of music
that is not already on the phone. While the file is on its way the action
cancels it; where it was never started, or was stopped part of the way
through, the action fetches it, and only fetches it: nothing is opened and
nothing is played. A download taken up again carries on from where it was
stopped, as it does for the button that is drawn.
The action is not offered for what is already here, nor for a message
still on its way out.
Checking it
With TalkBack on, swipe onto a video or a piece of music that is not on the device and open the actions.
Before, the only way to fetch it was to activate the message, which opens the viewer or starts playing. Now there is a download action that only fetches it. While it is on its way the same action cancels it, and using it again carries on from where it stopped.
Nothing is offered for a file that is already here.