Skip to content

Give a video and a piece of music a download of their own - #2041

Open
mehranlatifi83 wants to merge 1 commit into
DrKLO:masterfrom
mehranlatifi83:fix/talkback-no-download-action-for-media
Open

Give a video and a piece of music a download of their own#2041
mehranlatifi83 wants to merge 1 commit into
DrKLO:masterfrom
mehranlatifi83:fix/talkback-no-download-action-for-media

Conversation

@mehranlatifi83

@mehranlatifi83 mehranlatifi83 commented Aug 30, 2026

Copy link
Copy Markdown

Summary

A video and a piece of music are the two worth having on the phone before
they are wanted, and the two whose downloads run long enough to be worth
stopping. Neither could be asked for on its own.

Pressing the message is all there was, and pressing it does something
else: it opens the viewer, and streams what has not arrived, or it starts
playing. Keeping the file was only ever a side effect of watching or
listening to it, and stopping the download was reachable only in the
states where pressing the message happened to mean cancel.

Both are now an action of their own, on a video and on a piece of music
that is not already on the phone. While the file is on its way the action
cancels it; where it was never started, or was stopped part of the way
through, the action fetches it, and only fetches it: nothing is opened and
nothing is played. A download taken up again carries on from where it was
stopped, as it does for the button that is drawn.

The action is not offered for what is already here, nor for a message
still on its way out.

Checking it

With TalkBack on, swipe onto a video or a piece of music that is not on the device and open the actions.

Before, the only way to fetch it was to activate the message, which opens the viewer or starts playing. Now there is a download action that only fetches it. While it is on its way the same action cancels it, and using it again carries on from where it stopped.

Nothing is offered for a file that is already here.

A video and a piece of music are the two worth having on the phone before
they are wanted, and the two whose downloads run long enough to be worth
stopping. Neither could be asked for on its own.

Pressing the message is all there was, and pressing it does something
else: it opens the viewer, and streams what has not arrived, or it starts
playing. Keeping the file was only ever a side effect of watching or
listening to it, and stopping the download was reachable only in the
states where pressing the message happened to mean cancel.

Both are now an action of their own, on a video and on a piece of music
that is not already on the phone. While the file is on its way the action
cancels it; where it was never started, or was stopped part of the way
through, the action fetches it, and only fetches it: nothing is opened and
nothing is played. A download taken up again carries on from where it was
stopped, as it does for the button that is drawn.

The action is not offered for what is already here, nor for a message
still on its way out.
@mehranlatifi83
mehranlatifi83 force-pushed the fix/talkback-no-download-action-for-media branch from 6036541 to bcd63a8 Compare August 30, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant