Merge pull request #90 from EFNext/fix/nonpublic-interface-accessors

include non-public accessors when resolving implementing properties

Author: koenbeuk

src/ExpressiveSharp/Extensions/TypeExtensions.cs

@@ -122,7 +122,7 @@ private static MethodInfo GetImplementingMethod(this Type derivedType, MethodInf
 
     public static PropertyInfo GetImplementingProperty(this Type derivedType, PropertyInfo propertyInfo)
     {
-        var accessor = propertyInfo.GetAccessors()[0];
+        var accessor = propertyInfo.GetAccessors(true)[0];
 
         var implementingAccessor = derivedType.GetImplementingMethod(accessor);
         if (implementingAccessor == accessor)

tests/ExpressiveSharp.Tests/Extensions/TypeExtensionsTests.cs

@@ -110,4 +110,27 @@ public void GetConcreteProperty_SameDeclaringType_ReturnsOriginal()
 
         Assert.AreEqual(animalName, result);
     }
+
+    public interface IHidden
+    {
+        internal string Secret { get; }
+    }
+
+    public class HiddenImpl : IHidden
+    {
+        string IHidden.Secret => "s";
+    }
+
+    [TestMethod]
+    public void GetConcreteProperty_InterfacePropertyWithNonPublicAccessor_DoesNotThrow()
+    {
+        var interfaceProperty = typeof(IHidden)
+            .GetProperty(nameof(IHidden.Secret), BindingFlags.NonPublic | BindingFlags.Instance);
+        Assert.IsNotNull(interfaceProperty);
+
+        var result = typeof(HiddenImpl).GetConcreteProperty(interfaceProperty);
+
+        Assert.IsNotNull(result);
+        Assert.AreEqual(typeof(HiddenImpl), result.DeclaringType);
+    }
 }