fixed the cppcheck blocker

Author: zekageri

src/esp_crypto/crypto_asymmetric.cpp

@@ -731,6 +731,7 @@ CryptoResult<std::vector<uint8_t>> ESPCrypto::ecdsaDerToRaw(CryptoSpan<const uin
 
 CryptoResult<std::vector<uint8_t>> ESPCrypto::ecdsaRawToDer(CryptoSpan<const uint8_t> raw) {
 	return ecdsaRawToDerInternal(raw);
+}
 
 CryptoResult<std::vector<uint8_t>>
 ESPCrypto::x25519(CryptoSpan<const uint8_t> privateKey, CryptoSpan<const uint8_t> peerPublic) {

src/esp_crypto/crypto_core.cpp

@@ -41,9 +41,7 @@ void resetRuntimeState() {
 	GlobalRuntimeState &state = runtimeState();
 	state.nvsInitMap.clear();
 #if ESPCRYPTO_ENABLE_NONCE_GUARD
-	for (auto &record : state.nonceCache) {
-		record = NonceRecord{};
-	}
+	std::fill(state.nonceCache.begin(), state.nonceCache.end(), NonceRecord{});
 	state.nonceCursor = 0;
 #endif
 	state.bootCounter.store(0, std::memory_order_release);
@@ -68,16 +66,15 @@ bool nonceReused(const std::vector<uint8_t> &key, const std::vector<uint8_t> &iv
 	}
 	markRuntimeInitialized();
 	uint32_t keyHash = fingerprintKey(key);
-	for (const auto &record : state.nonceCache) {
-		if (!record.used || record.ivLen != iv.size()) {
-			continue;
-		}
-		if (record.keyHash != keyHash) {
-			continue;
-		}
-		if (memcmp(record.iv.data(), iv.data(), iv.size()) == 0) {
-			return true;
-		}
+	if (std::any_of(
+	        state.nonceCache.begin(),
+	        state.nonceCache.end(),
+	        [&](const NonceRecord &record) {
+		        return record.used && record.ivLen == iv.size() && record.keyHash == keyHash &&
+		               memcmp(record.iv.data(), iv.data(), iv.size()) == 0;
+	        }
+	    )) {
+		return true;
 	}
 	NonceRecord &slot = state.nonceCache[state.nonceCursor % state.nonceCache.size()];
 	slot.used = true;

src/esp_crypto/crypto_symmetric.cpp

@@ -210,6 +210,7 @@ bool hardwareAesCtr(
     const std::vector<uint8_t> &key,
     const std::vector<uint8_t> &nonceCounter,
     const std::vector<uint8_t> &input,
+    // cppcheck-suppress constParameterReference
     std::vector<uint8_t> &output
 ) {
 #if ESPCRYPTO_AES_ACCEL
@@ -331,7 +332,9 @@ bool hardwareGcmCrypt(
     const std::vector<uint8_t> &iv,
     const std::vector<uint8_t> &aad,
     const std::vector<uint8_t> &input,
+    // cppcheck-suppress constParameterReference
     std::vector<uint8_t> &output,
+    // cppcheck-suppress constParameterReference
     std::vector<uint8_t> &tag
 ) {
 	return hardwareGcmCryptSpan(
@@ -351,7 +354,9 @@ bool softwareGcmCrypt(
     const std::vector<uint8_t> &iv,
     const std::vector<uint8_t> &aad,
     const std::vector<uint8_t> &input,
+    // cppcheck-suppress constParameterReference
     std::vector<uint8_t> &output,
+    // cppcheck-suppress constParameterReference
     std::vector<uint8_t> &tag
 ) {
 	return softwareGcmCrypt(