no-throw/thread-safe baseline

Author: zekageri

.github/workflows/ci.yml

@@ -8,8 +8,22 @@ on:
   workflow_dispatch:
 
 jobs:
+  source-audit:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Audit production sources
+        run: |
+          if rg -n '\bthrow\b|std::abort\(' src; then
+            echo "Embedded safety audit failed"
+            exit 1
+          fi
+
   build-examples:
     runs-on: ubuntu-latest
+    needs: source-audit
     strategy:
       fail-fast: false
       matrix:
@@ -56,6 +70,7 @@ jobs:
 
   arduino-cli:
     runs-on: ubuntu-latest
+    needs: source-audit
     env:
       ESP32_CORE_VERSION: 3.3.3
       ARDUINO_BOARDS: |

library.json

@@ -35,7 +35,8 @@
   "headers": ["ESPMemoryMonitor.h"],
   "build": {
     "flags": [
-      "-std=gnu++17"
+      "-std=gnu++17",
+      "-fno-exceptions"
     ]
   }
 }

src/esp_memory_monitor/memory_monitor.cpp

@@ -26,6 +26,22 @@ inline size_t saturatingSubtract(size_t value, size_t delta) {
 	return value > delta ? value - delta : 0;
 }
 
+template <typename Callback, typename... Args>
+void invokeMemoryMonitorCallback(const Callback &callback, Args... args) noexcept {
+	if (!callback) {
+		return;
+	}
+
+#if defined(__cpp_exceptions)
+	try {
+		callback(args...);
+	} catch (...) {
+	}
+#else
+	callback(args...);
+#endif
+}
+
 } // namespace
 
 ESPMemoryMonitor *gPanicInstance = nullptr;
@@ -230,18 +246,18 @@ MemorySnapshot ESPMemoryMonitor::sampleNow() {
 
 	for (const auto &evt : events) {
 		if (thresholdCb) {
-			thresholdCb(evt);
+			invokeMemoryMonitorCallback(thresholdCb, evt);
 		}
 	}
 
 	for (const auto &evt : stackEvents) {
 		if (stackCb) {
-			stackCb(evt);
+			invokeMemoryMonitorCallback(stackCb, evt);
 		}
 	}
 
 	if (sampleCb) {
-		sampleCb(publicSnapshot);
+		invokeMemoryMonitorCallback(sampleCb, publicSnapshot);
 	}
 
 	return publicSnapshot;
@@ -369,7 +385,7 @@ LeakCheckResult ESPMemoryMonitor::markLeakCheckPoint(const std::string &label) {
 	LeakCheckResult result = toPublicLeakCheckResult(internal);
 
 	if (cb && !result.deltas.empty()) {
-		cb(result);
+		invokeMemoryMonitorCallback(cb, result);
 	}
 
 	return result;
@@ -547,12 +563,12 @@ ScopeStats ESPMemoryMonitor::finalizeScope(const MemoryScope &scope) {
 	}
 
 	if (scopeCb) {
-		scopeCb(toPublicScopeStats(stats));
+		invokeMemoryMonitorCallback(scopeCb, toPublicScopeStats(stats));
 	}
 
 	if (tagCb) {
 		for (const auto &evt : tagEvents) {
-			tagCb(evt);
+			invokeMemoryMonitorCallback(tagCb, evt);
 		}
 	}
 
@@ -716,7 +732,7 @@ void ESPMemoryMonitor::handleAllocEvent(
 	event.functionName = functionName;
 	event.timestampUs = esp_timer_get_time();
 
-	cb(event);
+	invokeMemoryMonitorCallback(cb, event);
 }
 
 void ESPMemoryMonitor::allocFailedHook(
@@ -1189,7 +1205,7 @@ void ESPMemoryMonitor::runPanicHook() {
 	}
 
 	if (cb) {
-		cb(snapshot);
+		invokeMemoryMonitorCallback(cb, snapshot);
 	}
 }
 

src/esp_memory_monitor/memory_monitor_allocator.h

@@ -62,20 +62,12 @@ template <typename T> class MemoryMonitorAllocator {
 			return nullptr;
 		}
 		if (n > (std::numeric_limits<std::size_t>::max() / sizeof(T))) {
-#if defined(__cpp_exceptions)
-			throw std::bad_alloc();
-#else
-			std::abort();
-#endif
+			return nullptr;
 		}
 
 		void *memory = memory_monitor_allocator_detail::allocate(n * sizeof(T), _usePSRAMBuffers);
 		if (memory == nullptr) {
-#if defined(__cpp_exceptions)
-			throw std::bad_alloc();
-#else
-			std::abort();
-#endif
+			return nullptr;
 		}
 
 		return static_cast<T *>(memory);