CI: remove unused library - #207
Closed
casperdcl wants to merge 1 commit into
Closed
Conversation
5 tasks
Contributor
|
This library is generated by Lines 40 to 44 in ddbcf12 It is referenced I've created #208. This works locally (let's see what CI says). It does fail when I remove |
Contributor
|
If you can change the CMakeLists.txt to avoid creating the .a (I couldn't), feel free, but I have no headspace for this anymore and won't be able to review. I strongly suggest to close and got onto more urgent stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #199 (comment) it seems the static lib is a CMake build hack which isn't actually necessary nor desired for distribution in a header-only package.
This PR:
tar.gzfrom 1.8MB to 0.066MB)cpp/examplesstill builds sanslibpetsird.a