add test if external C++ project can use PETSIRD - #208
Closed
KrisThielemans wants to merge 1 commit into
Closed
Conversation
KrisThielemans
force-pushed
the
add_external_project_test
branch
from
August 19, 2026 13:48
cfdfa12 to
088e084
Compare
This was referenced Aug 19, 2026
casperdcl
requested changes
Aug 19, 2026
casperdcl
left a comment
casperdcl
left a comment
Member
There was a problem hiding this comment.
Seems better to make a few tweaks to the existing cpp/examples folder instead. I only noticed a couple of diffs:
CCACHE_PROGRAM#ifdef #include hdf5/protocols.h #else binary/protocols.h
Contributor
Author
|
yeah, but the examples folder are built with |
Contributor
Author
|
we could copy files etc, but the advantage of this is that it's a nice and clean demo of how people should use an installed PETSIRD. |
Contributor
Author
|
BTW a some point we'll get rid of the HDF5 stuff... |
Contributor
Author
|
amazingly, we had this in cpp/example already... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minimal test. just checks if it compiles and links.