Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

Use variables to change the GoogleSignIn and the GoogleUtilities library version - #748

Open
marioshtika wants to merge 2 commits into
EddyVerbruggen:masterfrom
marioshtika:master
Open

Use variables to change the GoogleSignIn and the GoogleUtilities library version#748
marioshtika wants to merge 2 commits into
EddyVerbruggen:masterfrom
marioshtika:master

Conversation

@marioshtika

Copy link
Copy Markdown

No description provided.

@marioshtika

Copy link
Copy Markdown
Author

Hello @EddyVerbruggen,

as mentioned in this issue #653, when the same library (in my case GoogleUtilities) is being installed from two or more different plugins with different versions, the installation of this plugin will fail. Unless we use the same version of the specific library in all plugins.

To do so we need to give the version of the wanted library as a variable while installing the plugin.
For example

cordova plugin add https://github.com/EddyVerbruggen/cordova-plugin-googleplus --save --variable REVERSED_CLIENT_ID=myreversedclientid  --variable WEB_APPLICATION_CLIENT_ID=mywebapplicationclientid --variable GoogleUtilities="~> 6.7.0"

This is optional, so if the variable is not set, the default version will be used.

I have tested this and it is working as it should.

Let me know if you need anything else for this pull request to be merged.

Thank you in advance.

@msalmikais

Copy link
Copy Markdown

this commit is useful!!! why no one validates the merge?

@juanmaldonadodev

Copy link
Copy Markdown

Is someone going to review this one?

@marioshtika

Copy link
Copy Markdown
Author

Hello @EddyVerbruggen,

any update on this pull request. Will this be merged?

Thank you in advance.

@booleanbetrayal

Copy link
Copy Markdown

FWIW - I've bundled this change (with tweaks) into #764

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants