Fix: remove duplicate cls assignment for annotationView - #272
Merged
daniel-jettka merged 3 commits intoAug 26, 2026
Merged
Conversation
fmacca
approved these changes
Aug 26, 2026
fmacca
left a comment
fmacca
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me!
The 'annotView' assignement was probably overwritten
github-project-automation
Bot
moved this from In Progress
to Approved
in Edirom Development
daniel-jettka
deleted the
fix-222-duplicate-cls-assignemnt-for-annotationview
branch
August 26, 2026 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description, Context and related Issue
EdiromOnline.view.window.AnnotationView had two cls properties
-> removed cls: 'annotView'
Refs #222
How Has This Been Tested?
Opened first annotation in Klarinettenquintett's Autograph A and compared old and new version.
Types of changes
Overview