Remove FontAwesome dependency from edirom-image-viewer by making anno… - #275
Open
hizclick wants to merge 2 commits into
Conversation
…tation stylesheet injection and category icons fully host-driven; closes #271.
…hen building zones-data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description, Context and related Issue
Removes the FontAwesome dependency from
edirom-image-viewerby making both annotation stylesheet injection and category icon rendering fully host-driven, instead of hardcoded inside the component:edirom-image-viewer.js(submodule): replaced the hardcodedresources/css/annotation-style.css/resources/css/font-awesome.min.csspaths and thegetPreference()//db/lookup with a genericoverlay-stylesheetsattribute (host-supplied hrefs/markers, cloned from the host<head>into the shadow root via_applyOverlayStylesheets()), and a genericzone.iconHtmlfield in_renderOverlays()(host-supplied markup inserted as-is). The component now has no built-in knowledge of any file path, preference API, eXist-db convention, or icon system — keeping it reusable outside Edirom-Online-Frontend.OpenSeaDragonViewer.js(bridge): computes and setsoverlay-stylesheetsininitSurface()(annotation-style.css + the resolvedadditional_css_pathedition CSS) — the Edirom-specific lookup now lives here instead of in the shared component.annotation-style.css: removed the 2 FontAwesome::beforeglyph rules (beschreibung,rasurTektur); added centering +--edirom-icon-size/--edirom-icon-colorrules for anedirom-iconchild element in their place.Refs #271
How Has This Been Tested?
Types of changes
Overview