Skip to content

[andino_firmware] Remove unused read analog GPIO command #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jballoffet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[andino_firmware] Remove unused read analog GPIO command #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions andino_firmware/include/andino/app/app.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,6 @@ class App {
/// Callback method for an unknown command (default).
static void cmd_unknown_cb(void* context, int argc, char** argv);

/// Callback method for the `Commands::kReadAnalogGpio` command.
static void cmd_read_analog_gpio_cb(void* context, int argc, char** argv);

/// Callback method for the `Commands::kReadDigitalGpio` command.
static void cmd_read_digital_gpio_cb(void* context, int argc, char** argv);

Expand Down
2 changes: 0 additions & 2 deletions andino_firmware/include/andino/app/commands.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ namespace andino {

/// @brief CLI commands.
struct Commands {
/// @brief Reads an analog GPIO.
static constexpr const char* kReadAnalogGpio{"a"};
/// @brief Reads a digital GPIO.
static constexpr const char* kReadDigitalGpio{"d"};
/// @brief Reads the encoders tick count values.
Expand Down
10 changes: 0 additions & 10 deletions andino_firmware/src/app/app.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ void App::setup() {
// Initialize command shell.
shell_.set_serial_stream(&serial_stream_);
shell_.set_default_callback(cmd_unknown_cb);
shell_.register_command(Commands::kReadAnalogGpio, cmd_read_analog_gpio_cb, this);
shell_.register_command(Commands::kReadDigitalGpio, cmd_read_digital_gpio_cb, this);
shell_.register_command(Commands::kReadEncoders, cmd_read_encoders_cb, this);
shell_.register_command(Commands::kResetEncoders, cmd_reset_encoders_cb, this);
Expand Down Expand Up @@ -140,15 +139,6 @@ void App::cmd_unknown_cb(void*, int, char**) {
Serial.println("Unknown command.");
}

void App::cmd_read_analog_gpio_cb(void*, int argc, char** argv) {
if (argc < 2) {
return;
}

const int pin = atoi(argv[1]);
Serial.println(analogRead(pin));
}

void App::cmd_read_digital_gpio_cb(void*, int argc, char** argv) {
if (argc < 2) {
return;
Expand Down
Loading