Skip to content

Commit e18e679

Browse files
committed
fix: Fixed API Typings and all grump issues
- Fixed error during REST API schema generation - Use Fully Qualified Class Names in the Docs of Api interface methods. - Declared Strict Types - Fixed Code Quality issues - Removed unnecessary issue ignores - Run all Grumphp tasks in the Grumphp workflow - Added missing package requirement - Use `phpstan.neon` from `emico/code-quality`
1 parent 537db7b commit e18e679

79 files changed

Lines changed: 886 additions & 578 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/grumphp.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ jobs:
1919
composer2 config gitlab-token.git.emico.io ${{ secrets.GITLAB_TOKEN }}
2020
composer2 install --dev --prefer-dist --no-scripts --no-progress --optimize-autoloader --no-interaction -vvv
2121
composer2 show
22-
vendor/bin/grumphp run --tasks=phpmd,phpcs,xmllint,phplint,composer --no-interaction
22+
vendor/bin/grumphp run --no-interaction
2323
shell: bash

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
"require": {
55
"php": "^8.1",
66
"magento/module-sitemap": "^100.2||^100.4",
7-
"magento/module-catalog": "^102.0||^103.0||^104.0"
7+
"magento/module-catalog": "^102.0||^103.0||^104.0",
8+
"magento/module-layered-navigation": "^100.4"
89
},
910
"require-dev": {
1011
"emico/code-quality": "~10.6.0",

grumphp.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ grumphp:
3030
short_open_tag: true
3131

3232
composer:
33+
no_check_lock: true
3334
no_check_publish: true
3435
with_dependencies: false
3536
strict: false

phpstan.neon

Lines changed: 0 additions & 27 deletions
This file was deleted.

phpstan.neon

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
vendor/emico/code-quality/config-templates/phpstan.neon

src/Api/Data/FilterInterface.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
<?php // phpcs:ignore SlevomatCodingStandard.TypeHints.DeclareStrictTypes.DeclareStrictTypesMissing
1+
<?php
22

33
/**
44
* @author Bram Gerritsen <bgerritsen@emico.nl>
55
* @copyright (c) Emico B.V. 2019
66
*/
77

8+
declare(strict_types=1);
9+
810
namespace Emico\AttributeLanding\Api\Data;
911

1012
interface FilterInterface

0 commit comments

Comments
 (0)