Remove individual metadata files from defaultinfo

We absolutely do not need the individual metadata files in the data
folder, the merged one is enough

Author: furtib

src/per_file.bzl

@@ -91,7 +91,6 @@ def _run_code_checker(
         clang_tidy_plist,
         clangsa_plist,
         codechecker_log,
-        codechecker_metadata,
     ]
 
     analyzer_output_paths = "clangsa," + clangsa_plist.path + \
@@ -103,7 +102,9 @@ def _run_code_checker(
     # Action to run CodeChecker for a file
     ctx.actions.run(
         inputs = inputs,
-        outputs = outputs,
+        # We do not want all individual metadata files
+        # cluttering the data folder
+        outputs = outputs + [codechecker_metadata],
         executable = ctx.outputs.per_file_script,
         arguments = [
             info.codechecker.path,
@@ -119,7 +120,7 @@ def _run_code_checker(
         use_default_shell_env = True,
         progress_message = "CodeChecker analyze {}".format(src.short_path),
     )
-    return outputs
+    return outputs, codechecker_metadata
 
 def check_valid_file_type(src):
     """
@@ -177,13 +178,12 @@ def _create_wrapper_script(ctx, options, compile_commands_json, config_file):
         },
     )
 
-def _merge_metadata(ctx, all_files):
+def _merge_metadata(ctx, metadata):
     """
     Merges metadata files of individual CodeChecker runs into 1
 
     Returns the metadata file objects
     """
-    metadata = [file for file in all_files if file.path.endswith("metadata.json")]
     metadata_json = ctx.actions.declare_file(ctx.attr.name + "/data/metadata.json")
     ctx.actions.run(
         inputs = metadata,
@@ -207,6 +207,7 @@ def _per_file_impl(ctx):
     sources_and_headers = _collect_all_sources_and_headers(ctx)
     options = ctx.attr.default_options + ctx.attr.options
     all_files = [compile_commands]
+    all_metadata = []
     config_file, env_vars = get_config_file(ctx)
     _create_wrapper_script(ctx, options, compile_commands, config_file)
     for target in ctx.attr.targets:
@@ -221,7 +222,7 @@ def _per_file_impl(ctx):
                     if not check_valid_file_type(src):
                         continue
                     args = target[SourceFilesInfo].compilation_db.to_list()
-                    outputs = _run_code_checker(
+                    outputs, metadata = _run_code_checker(
                         ctx,
                         src,
                         args,
@@ -235,7 +236,8 @@ def _per_file_impl(ctx):
                         sources_and_headers,
                     )
                     all_files += outputs
-    all_files.append(_merge_metadata(ctx, all_files))
+                    all_metadata.append(metadata)
+    all_files.append(_merge_metadata(ctx, all_metadata))
     ctx.actions.write(
         output = ctx.outputs.test_script,
         is_executable = True,