fix(cross-model): accept Codex CLI effort values none and max - #1567
fix(cross-model): accept Codex CLI effort values none and max#1567khsaurabh wants to merge 2 commits into
Conversation
The effort whitelist was a stale copy of the Codex enum, so pinning cross_model_effort to none or max skipped the peer as incompatible. Keep fail-closed for values the route cannot honor. Rebased onto current main via Git Data API (OAuth lacks workflow scope for pushing main CI history).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68fbadb210
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
302090f to
4e79025
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e790258c9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Keep the Codex none/max effort change from dropping +x on cross-model-adversarial-review.sh and cross-model-doc-review.sh.
1 participant
Summary
cross_model_effortrejected Codex CLI valuesnoneandmaxeven though those are validmodel_reasoning_effortenums (Codex CLI 0.150.1). Fail-closed is still correct for values the route cannot honor; the whitelist was a stale copy of the provider enum.This PR adds
codex:noneandcodex:maxto both review workers (validate_effort_overridestays byte-identical), updates the comment/docs/config copies of that list, and pins the seven-value enum in tests so the next CLI addition cannot silently drift.Editorial default remains
xhigh.ce-work/ce-povhardcodedhighis unchanged.Validation
bun test tests/skills/ce-code-review-cross-model-routes.test.ts tests/skills/ce-setup-check-health.test.ts— 161 passbun run release:validate— in syncCloses #1565
Security Disclosure
No security-relevant changes.
Agent Disclosure