feat(tls): initialize crypto provider for rustls and enhance database container configuration

- Added `init_crypto_provider` function to initialize the crypto provider for rustls, ensuring secure connections.
- Updated `main.rs` to call the new initialization function at startup.
- Enhanced `DatabaseContainer` to support TLS configurations, including validation and secure defaults for MySQL and MariaDB containers.
- Refactored `TestDatabase` to include TLS-enabled variants for better integration testing.

These changes improve the security posture of the Gold Digger project by ensuring proper TLS setup for database connections.

Author: unclesp1d3r

src/lib.rs

@@ -1,8 +1,17 @@
-use std::{env, ffi::OsStr, path::Path};
+use std::{env, ffi::OsStr, path::Path, sync::Once};
 
 use anyhow::{Context, Result};
 use mysql::Row;
 
+static INIT: Once = Once::new();
+
+/// Initialize crypto provider for rustls
+pub fn init_crypto_provider() {
+    INIT.call_once(|| {
+        let _ = rustls::crypto::ring::default_provider().install_default();
+    });
+}
+
 /// CLI interface module.
 pub mod cli;
 /// CSV output module.

src/main.rs

@@ -42,6 +42,9 @@ fn redact_sql_error(message: &str) -> String {
 ///
 /// Parses CLI arguments and environment variables, executes a database query, and writes the output in the specified format.
 fn main() {
+    // Initialize crypto provider for rustls
+    gold_digger::init_crypto_provider();
+
     let cli = Cli::parse();
 
     // Handle subcommands first

tests/README.md

@@ -1,6 +1,7 @@
 # Gold Digger Integration Tests
 
-This directory contains comprehensive integration tests for Gold Digger's MySQL/MariaDB functionality, including TLS support, data type handling, and output format validation.
+This directory contains comprehensive integration tests for Gold Digger's MySQL/MariaDB
+functionality, including TLS support, data type handling, and output format validation.
 
 ## Test Structure
 
@@ -117,8 +118,10 @@ cargo test --features "integration_tests additional_mysql_types" -- --include-ig
 
 #### Current Test Categories
 
-1. **Unit Tests** (`tls_unit_tests`): Test TLS configuration and validation without external dependencies
-2. **TLS Integration Tests** (`tls_integration`): Test actual TLS connections and certificate validation (require Docker)
+1. **Unit Tests** (`tls_unit_tests`): Test TLS configuration and validation without external
+   dependencies
+2. **TLS Integration Tests** (`tls_integration`): Test actual TLS connections and certificate
+   validation (require Docker)
 3. **Type Safety Tests** (`type_safety`): Test MySQL data type conversion and NULL value handling
 4. **Exit Code Tests** (`exit_codes`): Test proper exit code mapping for different error scenarios
 

tests/fixtures/seed_data.sql

@@ -1,15 +1,15 @@
 -- Basic test data
 INSERT INTO test_basic (item_name, table_value)
-VALUES ('test1', 100)
-ON DUPLICATE KEY UPDATE table_value = VALUES (table_value);
+VALUES ('test1', 100) AS new
+ON DUPLICATE KEY UPDATE table_value = new.table_value;
 
 INSERT INTO test_basic (item_name, table_value)
-VALUES ('test2', 200)
-ON DUPLICATE KEY UPDATE table_value = VALUES (table_value);
+VALUES ('test2', 200) AS new
+ON DUPLICATE KEY UPDATE table_value = new.table_value;
 
 INSERT INTO test_basic (item_name, table_value)
-VALUES ('test3', 300)
-ON DUPLICATE KEY UPDATE table_value = VALUES (table_value);
+VALUES ('test3', 300) AS new
+ON DUPLICATE KEY UPDATE table_value = new.table_value;
 
 -- Comprehensive data types test data
 INSERT INTO test_data_types (
@@ -53,8 +53,27 @@ VALUES (
     'medium',
     'red,blue',
     TRUE
-)
-ON DUPLICATE KEY UPDATE varchar_col = VALUES (varchar_col);
+) AS new
+ON DUPLICATE KEY UPDATE
+    varchar_col = new.varchar_col,
+    text_col = new.text_col,
+    int_col = new.int_col,
+    bigint_col = new.bigint_col,
+    decimal_col = new.decimal_col,
+    float_col = new.float_col,
+    double_col = new.double_col,
+    date_col = new.date_col,
+    datetime_col = new.datetime_col,
+    timestamp_col = new.timestamp_col,
+    time_col = new.time_col,
+    year_col = new.year_col,
+    binary_col = new.binary_col,
+    varbinary_col = new.varbinary_col,
+    blob_col = new.blob_col,
+    json_col = new.json_col,
+    enum_col = new.enum_col,
+    set_col = new.set_col,
+    bool_col = new.bool_col;
 
 -- Edge cases test data
 INSERT INTO test_edge_cases (
@@ -78,10 +97,10 @@ VALUES (
     '12345',
     0,
     -42
-)
-ON DUPLICATE KEY UPDATE unicode_text = VALUES (unicode_text);
+) AS new
+ON DUPLICATE KEY UPDATE unicode_text = new.unicode_text;
 
-INSERT INTO test_edge_cases (
+INSERT INTO test_edge_cases AS new (
     id,
     null_varchar,
     empty_string,
@@ -103,4 +122,4 @@ VALUES (
     0,
     -100
 )
-ON DUPLICATE KEY UPDATE unicode_text = VALUES (unicode_text);
+ON DUPLICATE KEY UPDATE unicode_text = new.unicode_text;

tests/integration/common.rs

@@ -328,7 +328,7 @@ impl TestEnvironment {
         // Store original value for restoration
         self.original_env.insert(key.to_string(), std::env::var(key).ok());
 
-        // Set new value
+        // Set new value - std::env::set_var is safe in single-threaded tests
         unsafe {
             std::env::set_var(key, value);
         }
@@ -339,7 +339,7 @@ impl TestEnvironment {
         // Store original value for restoration
         self.original_env.insert(key.to_string(), std::env::var(key).ok());
 
-        // Remove variable
+        // Remove variable - std::env::remove_var is safe in single-threaded tests
         unsafe {
             std::env::remove_var(key);
         }
@@ -356,13 +356,11 @@ impl Drop for TestEnvironment {
     /// Restore original environment variables when dropped
     fn drop(&mut self) {
         for (key, original_value) in &self.original_env {
-            match original_value {
-                Some(value) => unsafe {
-                    std::env::set_var(key, value);
-                },
-                None => unsafe {
-                    std::env::remove_var(key);
-                },
+            unsafe {
+                match original_value {
+                    Some(value) => std::env::set_var(key, value),
+                    None => std::env::remove_var(key),
+                }
             }
         }
     }