Repository navigation
Float Node.js on the 24.x line instead of pinning 24.22.1 - #888
Closed
NicolasBonet wants to merge 1 commit into
Closed
NicolasBonet wants to merge 1 commit into
NicolasBonet wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
melvin-bot
Bot
requested review from
marcaaron
and removed request for
a team
November 5, 2026 16:48
NicolasBonet
marked this pull request as draft
November 5, 2026 17:00
Contributor
Author
|
Closing for now: we haven't decided how to handle Node.js updates yet. See https://github.com/Expensify/Expensify/issues/696498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Node.js now floats on the 24.x line instead of being pinned to 24.22.1, so patch releases, including security fixes, reach CI without a PR in every repo.
.nvmrcholds the major only (24), and everysetup-nodestep (in the workflows and in thesetupNodecomposite action) setscheck-latest: true, so it installs the newest 24.x instead of the runner's cached version.Related Issues
For https://github.com/Expensify/Expensify/issues/696498
Linked E/App PR
None. This only changes the Node.js version used to develop, test and build Onyx. No library code or published package metadata changes, so there is nothing for E/App to pin.
Automated Tests
None needed. This only changes the Node.js version that CI and local development use; no library code changes.
Manual Tests
shellcheckon yourPATH, runREPO_ROOT=<path to this branch> bash scripts/actionlint.sh. It printedWorkflows passed actionlint!.rg --hidden -n nvmrc -g '!node_modules' -g '!.git'. The only matches arenode-version-file: .nvmrclines in the workflows and thesetupNodecomposite action, plus a comment inreassurePerfTests.yml, so nothing else expects.nvmrcto hold an exact version.nvm installand confirmnode -vprints the newest v24.x release.Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
None. This only changes the Node.js version used to develop, test and build.
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari