Repository navigation
Commit 8810220
committed
docs: correct mermaid-py behavior in comments (remote API, not local Node.js)
mermaid-py (>=0.8.0, the version this project pins) validates diagrams by
sending them to a remote rendering service (https://mermaid.ink by default,
overridable via mermaid-py's own MERMAID_INK_SERVER env var), not by
spawning a local Node.js subprocess. Verified by inspecting the mermaid-py
0.8.0 and 0.8.4 source directly (mermaid/__main__.py uses requests.get()
against MERMAID_INK_SERVER, no subprocess/child_process anywhere).
This corrects two comments that describe the old (inaccurate, or possibly
just always-wrong) assumption:
- codewiki/src/be/utils.py: the _MERMAID_PY_BROKEN comment
- pyproject.toml: the nodejs build-requires comment
No functional change. The nodejs build-requires entry itself is left as-is
since I couldn't confirm whether it's needed for something else in the
project; flagging it for maintainers to reconsider.1 parent 9ed15ba commit 8810220
2 files changed
Lines changed: 10 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
154 | | - | |
155 | | - | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
156 | 159 | | |
157 | 160 | | |
158 | 161 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
68 | 72 | | |
69 | 73 | | |
70 | 74 | | |
| |||
0 commit comments