llm_services: fall back to ModelHTTPError when pydantic-ai has no ModelAPIError

requirements.txt pins pydantic-ai 1.0.6, which predates ModelAPIError, so
the import failed and CI could not collect any test.

Author: anhnh2002

codewiki/src/be/llm_services.py

@@ -13,7 +13,12 @@
 
 from openai.types import chat
 
-from pydantic_ai.exceptions import ModelAPIError, ModelHTTPError, UnexpectedModelBehavior
+from pydantic_ai.exceptions import ModelHTTPError, UnexpectedModelBehavior
+
+try:  # pydantic-ai >= 1.x adds ModelAPIError as the parent of ModelHTTPError
+    from pydantic_ai.exceptions import ModelAPIError
+except ImportError:  # older releases (e.g. the pinned 1.0.6) only have ModelHTTPError
+    ModelAPIError = ModelHTTPError
 from pydantic_ai.models.openai import OpenAIChatModel, OpenAIChatModelSettings
 from pydantic_ai.models.fallback import FallbackModel
 from pydantic_ai.providers.openai import OpenAIProvider
@@ -254,9 +259,10 @@ def create_fallback_models(config: Config) -> FallbackModel:
     """Create fallback models chain from configuration."""
     main = create_main_model(config)
     fallback = create_fallback_model(config)
-    # The default fallback_on=(ModelAPIError,) misses UnexpectedModelBehavior, which
-    # pydantic-ai raises for a 200 response whose body does not parse (e.g. choices=None
-    # from an OpenAI-compatible gateway); without it such a response skips the fallback.
+    # The default fallback_on (ModelAPIError, or ModelHTTPError on older pydantic-ai)
+    # misses UnexpectedModelBehavior, which pydantic-ai raises for a 200 response whose
+    # body does not parse (e.g. choices=None from an OpenAI-compatible gateway); without
+    # it such a response skips the fallback model.
     return FallbackModel(main, fallback, fallback_on=(ModelAPIError, UnexpectedModelBehavior))
 
 

tests/test_agent_limits.py

@@ -5,7 +5,7 @@
 from pathlib import Path
 from types import SimpleNamespace
 
-from pydantic_ai.exceptions import ModelAPIError, UnexpectedModelBehavior
+from pydantic_ai.exceptions import UnexpectedModelBehavior
 
 import codewiki.src.be.agent_tools.generate_sub_module_documentations as sub_mod
 import codewiki.src.be.llm_services as llm_services
@@ -55,7 +55,7 @@ def test_fallback_covers_malformed_responses(monkeypatch):
     )
     llm_services.create_fallback_models(SimpleNamespace())
     # a 200 response with an unparseable body must also switch to the fallback model
-    assert set(captured["fallback_on"]) == {ModelAPIError, UnexpectedModelBehavior}
+    assert set(captured["fallback_on"]) == {llm_services.ModelAPIError, UnexpectedModelBehavior}
 
 
 def test_overview_system_prompt():