Skip to content

Commit 1a2af2c

Browse files
wormeymanclaude
andcommitted
Take CodeRabbit's two nits: drop the unused kept set, handle spawn's error event
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PiGqmKAaxnRnDXwND8rq2y
1 parent d76de26 commit 1a2af2c

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

crates/fmw-noise/src/fixtures.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6298,13 +6298,6 @@ fn the_oriented_tile_test_through_the_apply_stage() {
62986298
assert!(totals[1].wrong < totals[0].wrong);
62996299
assert!(totals[1].surplus < totals[0].surplus);
63006300
assert!(totals[1].missing < totals[0].missing);
6301-
// Every leftover is a cell the game's own collision test KEPT.
6302-
let kept: BTreeSet<(u64, u64)> = would_collide_calls(&calls)
6303-
.iter()
6304-
.flat_map(|(_, _, region)| region.iter())
6305-
.filter(|c| !c.result)
6306-
.map(|c| (c.x.to_bits(), c.y.to_bits()))
6307-
.collect();
63086301
assert_eq!(leftovers.len(), 16);
63096302
let tested: BTreeMap<(u64, u64), (u8, bool)> = would_collide_calls(&calls)
63106303
.iter()
@@ -6339,7 +6332,6 @@ fn the_oriented_tile_test_through_the_apply_stage() {
63396332
(1630.0, 1602.5, "north-to-west")
63406333
]
63416334
);
6342-
let _ = kept;
63436335
}
63446336

63456337
/// **The game tests every cell with its RAW queued orientation, and the port's

scripts/probes/vulcanus-cliff-wouldcollide/capture.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,12 @@ async function captureRegion(region: Region): Promise<{ calls: Call[]; cliffs: n
203203
child.kill("SIGKILL");
204204
reject(new Error("lldb replay timed out after 900s"));
205205
}, 900_000);
206+
// A missing lldb emits `error` and never `exit`; without this the
207+
// promise would sit until the timer fired and blame a timeout.
208+
child.on("error", (err) => {
209+
clearTimeout(timer);
210+
reject(new Error(`failed to start lldb: ${err.message}`));
211+
});
206212
child.on("exit", (code) => {
207213
clearTimeout(timer);
208214
if (!out.includes("probe: wrote")) {

0 commit comments

Comments
 (0)