Skip to content

Commit 9934a45

Browse files
wormeymanclaude
andcommitted
docs: fold check:vue into the places that enumerate verify's phases
`verify` gained a fourth phase, so three places that spell the list out went stale the moment it did. CLAUDE.md was updated in the parent commit; these were not: - `README.md` listed the gate as `vp check` + `vp test` + `preview:test` in two places (the script list and the deploy section) and had no `check:vue` entry at all, so the one command that type-checks `.vue` bodies was undiscoverable from the README. - `.github/workflows/verify.yml`'s comment said "its three phases". The count is the whole point of that comment - it explains why the workflow calls `pnpm run verify` verbatim instead of re-listing phases as steps. Comment-only in the YAML: no step is added and no phase is mirrored into CI, which is deliberate - `verify` stays the single definition and CI picks up the new phase with no workflow change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F3a2HLJ4beKARi7SPmaM54
1 parent e9ca151 commit 9934a45

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

.github/workflows/verify.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# days after the breaking merge) - see issue #54.
44
#
55
# This job deliberately runs `pnpm run verify` VERBATIM rather than re-listing
6-
# its three phases as separate steps. `verify` is the single definition of "the
6+
# its four phases as separate steps. `verify` is the single definition of "the
77
# repo is consistent"; splitting it here would create a second definition that
88
# can silently drift from package.json. Note it is `verify`, not `check` -
99
# `check` is `vp check --fix` and CI must never rewrite files.

README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,13 @@ root fails with `EBADDEVENGINES`).
8383

8484
- `pnpm install` - install dependencies
8585
- `pnpm vp dev` - dev server
86-
- `pnpm vp check --fix` - lint + format + type-check
86+
- `pnpm vp check --fix` - lint + format + type-check of `.ts`
87+
- `pnpm run check:vue` - `vue-tsc --noEmit`, the type-check of `<script setup>`
88+
bodies in the `.vue` files. Nothing else checks them.
8789
- `pnpm vp test` - test suite (fixture-driven codec tests and UI tests)
8890
- `pnpm vp build` - production build
89-
- `pnpm run verify` - the whole gate: `vp check` + `vp test` + `preview:test`.
90-
~65-90s locally. Needs no Factorio install.
91+
- `pnpm run verify` - the whole gate: `vp check` + `check:vue` + `vp test` +
92+
`preview:test`. ~65-90s locally. Needs no Factorio install.
9193

9294
### CI
9395

@@ -136,7 +138,7 @@ test: `pnpm --filter @fmw/preview-container test:integration`.
136138
The app and preview service are already deployed (Cloudflare Pages +
137139
Workers/Containers on the `wormeyman` account; `pnpm run deploy` verifies,
138140
builds, and publishes the app). Both deploy paths are gated: `pnpm run deploy`
139-
runs `pnpm run verify` (`vp check` + `vp test` + `preview:test`) first and
141+
runs `pnpm run verify` (`vp check` + `check:vue` + `vp test` + `preview:test`) first and
140142
aborts before `wrangler` if anything fails. The one-time setup, for reference, needs a Cloudflare account
141143
and Workers Paid ($5/mo, required for Containers):
142144

0 commit comments

Comments
 (0)