Skip to content

Stop quoting the Node version in prose, and correct the bare-vp claim - #411

Merged
wormeyman merged 1 commit into
mainfrom
docs/node-26.8.1-and-vp-claim
Sep 11, 2026
Merged

Stop quoting the Node version in prose, and correct the bare-vp claim#411
wormeyman merged 1 commit into
mainfrom
docs/node-26.8.1-and-vp-claim

Conversation

@wormeyman

@wormeyman wormeyman commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Post-merge cleanup after #402 (Node 26.8.1), plus a pre-existing README error found alongside it.

Why de-quote rather than update

Renovate edits .node-version and nothing else, so three places named a Node version that no bot maintains: README.md, CLAUDE.md, and the comment above setup-node in verify.yml.

Updating the number would only reset the clock. That file has moved four times since 2026-07-01 - 26.5.1, 26.7.0, 26.8.1 - and 26.8.2 is already queued on the dependency dashboard, so a number written in prose can only ever lag it.

This repo already documents the fix for exactly this class, twice:

Do not quote that pin here, read it with grep channel rust-toolchain.toml. This line named 1.97.1 from #219 until #316 moved the pin, and then stayed wrong.

Do not quote a byte count for engine.wasm from this file. Every ported op changes it and it has gone stale twice.

.node-version is the same class and never got the same treatment. These three lines now point at the file instead of naming a version.

docs/bun-deno-evaluation.md:4 keeps its 26.7.0 on purpose. It records the conditions a past measurement ran under (26.7.0, 229 spec files, 2020 tests), so changing it would falsify the record rather than update it.

The bare-vp claim

The same README paragraph said a bare vp "or npx vp from the project root fails with EBADDEVENGINES". Measured:

$ vp check          # vp v0.3.1
pass: All 281 files are correctly formatted (565ms, 12 threads)
pass: Found no warnings, lint errors, or type errors in 253 files
exit 0

Only npx vp fails - the project pins pnpm via devEngines, and the global vp binary is not npm. CLAUDE.md already carries this correction (re-measured 2026-08-04) and explicitly warns against "fixing" a working command on the strength of the old claim. The README never got it. The operative advice is unchanged: prefer pnpm vp, because that is the form package.json and CI use and so the one that stays verified.

Checks run

  • pnpm run verify:lint - vp check (281 files formatted, 253 files clean) and check:vue, exit 0.
  • Before merging Update Node.js to v26.8.1 #402, a full pnpm run verify on Node 26.8.1: exit 0, with vp cache clean run first so the content-cached test phase could not replay a 26.7.0 result. Since verify chains its phases, verify:rust completing last is itself evidence the earlier phases passed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TSoJPryVM4vP3uB2iXeV2X

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a3f6cb98-8a76-4c91-affc-4aa59651d77a

📥 Commits

Reviewing files that changed from the base of the PR and between 68ff1f1 and 7a3f88a.

📒 Files selected for processing (3)
  • .github/workflows/verify.yml
  • CLAUDE.md
  • README.md

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3fb38ee1-dbd4-4104-9370-7216d7574d3f

📥 Commits

Reviewing files that changed from the base of the PR and between f95b775 and 68ff1f1.

📒 Files selected for processing (3)
  • .github/workflows/verify.yml
  • CLAUDE.md
  • README.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change updates Node version references from 26.7.0 to 26.8.1. The README also updates the documented vp and npx vp behavior.

Changes

Node version documentation alignment

Layer / File(s) Summary
Align Node version and pnpm guidance
.github/workflows/verify.yml, CLAUDE.md, README.md
Workflow comments and development documentation now reference Node 26.8.1. The README documents that vp runs successfully and npx vp fails with EBADDEVENGINES.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 68ff1

The PR updates version documentation and corrects the documented command behavior without introducing runtime changes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies both main documentation changes: the Node.js version wording update and the correction to the bare vp claim. It is concise and specific.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/node-26.8.1-and-vp-claim

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

#402 moved `.node-version` to 26.8.1 and Renovate has 26.8.2 queued
already. Three places named a Node version that Renovate never edits:
README.md, CLAUDE.md, and the comment above `setup-node` in verify.yml.
Updating the number would just reset the clock - the file has moved four
times since 2026-07-01 (26.5.1, 26.7.0, 26.8.1, 26.8.2 queued).

So these now point at `.node-version` instead of naming a version. That
is the convention this repo already documents for two other pins: "Do
not quote that pin here, read it with `grep channel rust-toolchain.toml`"
(which named 1.97.1 for weeks after #316 moved it) and "Do not quote a
byte count for `engine.wasm` from this file." `.node-version` is the
same class and never got the same treatment.

`docs/bun-deno-evaluation.md` keeps its 26.7.0 deliberately: it records
the conditions a past measurement ran under, so rewriting it would
falsify the record rather than update it.

Separately, the README claimed a bare `vp` fails with `EBADDEVENGINES`.
It does not - measured here, `vp check` (v0.3.1) exits 0 and reports all
281 files formatted. Only `npx vp` fails. CLAUDE.md already carries that
correction from 2026-08-04 and warns against "fixing" a working command
on the strength of the old claim; the README never got it.

Verified on 26.8.1 before merging #402: full `pnpm run verify` exit 0,
with `vp cache clean` first so the cached test phase could not replay a
26.7.0 result.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TSoJPryVM4vP3uB2iXeV2X
@wormeyman
wormeyman force-pushed the docs/node-26.8.1-and-vp-claim branch from 68ff1f1 to 7a3f88a Compare September 11, 2026 15:55
@wormeyman wormeyman changed the title Update the Node version prose to 26.8.1 and correct the bare-vp claim Stop quoting the Node version in prose, and correct the bare-vp claim Sep 11, 2026
@wormeyman
wormeyman merged commit 1f4c31f into main Sep 11, 2026
10 checks passed
@wormeyman
wormeyman deleted the docs/node-26.8.1-and-vp-claim branch September 11, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant