Stop quoting the Node version in prose, and correct the bare-vp claim - #411
Conversation
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change updates Node version references from 26.7.0 to 26.8.1. The README also updates the documented ChangesNode version documentation alignment
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The PR updates version documentation and corrects the documented command behavior without introducing runtime changes. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
#402 moved `.node-version` to 26.8.1 and Renovate has 26.8.2 queued already. Three places named a Node version that Renovate never edits: README.md, CLAUDE.md, and the comment above `setup-node` in verify.yml. Updating the number would just reset the clock - the file has moved four times since 2026-07-01 (26.5.1, 26.7.0, 26.8.1, 26.8.2 queued). So these now point at `.node-version` instead of naming a version. That is the convention this repo already documents for two other pins: "Do not quote that pin here, read it with `grep channel rust-toolchain.toml`" (which named 1.97.1 for weeks after #316 moved it) and "Do not quote a byte count for `engine.wasm` from this file." `.node-version` is the same class and never got the same treatment. `docs/bun-deno-evaluation.md` keeps its 26.7.0 deliberately: it records the conditions a past measurement ran under, so rewriting it would falsify the record rather than update it. Separately, the README claimed a bare `vp` fails with `EBADDEVENGINES`. It does not - measured here, `vp check` (v0.3.1) exits 0 and reports all 281 files formatted. Only `npx vp` fails. CLAUDE.md already carries that correction from 2026-08-04 and warns against "fixing" a working command on the strength of the old claim; the README never got it. Verified on 26.8.1 before merging #402: full `pnpm run verify` exit 0, with `vp cache clean` first so the cached test phase could not replay a 26.7.0 result. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TSoJPryVM4vP3uB2iXeV2X
68ff1f1 to
7a3f88a
Compare
Post-merge cleanup after #402 (Node 26.8.1), plus a pre-existing README error found alongside it.
Why de-quote rather than update
Renovate edits
.node-versionand nothing else, so three places named a Node version that no bot maintains:README.md,CLAUDE.md, and the comment abovesetup-nodeinverify.yml.Updating the number would only reset the clock. That file has moved four times since 2026-07-01 - 26.5.1, 26.7.0, 26.8.1 - and 26.8.2 is already queued on the dependency dashboard, so a number written in prose can only ever lag it.
This repo already documents the fix for exactly this class, twice:
.node-versionis the same class and never got the same treatment. These three lines now point at the file instead of naming a version.docs/bun-deno-evaluation.md:4keeps its 26.7.0 on purpose. It records the conditions a past measurement ran under (26.7.0, 229 spec files, 2020 tests), so changing it would falsify the record rather than update it.The bare-
vpclaimThe same README paragraph said a bare
vp"ornpx vpfrom the project root fails withEBADDEVENGINES". Measured:Only
npx vpfails - the project pins pnpm viadevEngines, and the globalvpbinary is not npm. CLAUDE.md already carries this correction (re-measured 2026-08-04) and explicitly warns against "fixing" a working command on the strength of the old claim. The README never got it. The operative advice is unchanged: preferpnpm vp, because that is the formpackage.jsonand CI use and so the one that stays verified.Checks run
pnpm run verify:lint-vp check(281 files formatted, 253 files clean) andcheck:vue, exit 0.pnpm run verifyon Node 26.8.1: exit 0, withvp cache cleanrun first so the content-cached test phase could not replay a 26.7.0 result. Sinceverifychains its phases,verify:rustcompleting last is itself evidence the earlier phases passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01TSoJPryVM4vP3uB2iXeV2X