Skip to content

docs(ci): record the build job and the now-required build check - #66

Merged
wormeyman merged 1 commit into
mainfrom
docs/ci-build-required
Jul 30, 2026
Merged

docs(ci): record the build job and the now-required build check#66
wormeyman merged 1 commit into
mainfrom
docs/ci-build-required

Conversation

@wormeyman

Copy link
Copy Markdown
Collaborator

Follow-up to #64 and #65. Three claims went stale the moment those merged, and all three read as current fact:

  • verify.yml's header still listed pnpm vp build under "what is deliberately NOT here", 90 lines above the job that runs it.
  • Its concurrency comment still said strict_required_status_checks_policy is false. Ruleset EJ has had strict: true since chore(renovate): automerge GitHub Action digest re-pins, and only those (#62) #65's prerequisite landed - which is the whole reason the automerge rule was safe to add. The rationale for not cancelling main runs survives (a per-commit verdict on main is still the thing that proves it), so it is corrected, not deleted.
  • CLAUDE.md said the same thing about the build being absent, plus "the build stamp reads git history" - measured wrong in ci(build): run pnpm vp build - verify never did (#61) #64. It reads git state: rev-parse HEAD, rev-parse --short HEAD, status --porcelain.

Also records what actually happened after the merges:

  • build is now a required check in ruleset EJ, added after ci(build): run pnpm vp build - verify never did (#61) #64 was green on main. The table says verify + build.
  • The two-step ordering, because getting it backwards is self-blocking: requiring a check that does not exist on main blocks the PR that introduces it. Plus the PUT-replaces-rules gotcha, and the strict: true side effect that every other open PR needs Update branch after any merge.

Docs and comments only - no workflow behaviour changes.

Three stale claims, all reading as current fact after #64/#65 merged:

- verify.yml still listed `pnpm vp build` as deliberately absent, 90 lines
  above the job that runs it.
- Its concurrency comment still said strict_required_status_checks_policy
  is false; ruleset EJ has had strict: true since before #65 landed. The
  reason main runs stay uncancelled survives, so it is corrected in place.
- CLAUDE.md repeated the "build is absent" claim and the "build stamp reads
  git history" one that #64 measured wrong - it reads git *state*.

Adds what happened after: `build` is a required check now, the two-step
order for adding one (requiring a check that does not exist on main blocks
the PR that introduces it), that the ruleset PUT replaces the whole rules
array, and that strict: true means every other open PR needs Update branch
after any merge.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BkKb3S2cGyRFFHSzuCQBgj
@wormeyman
wormeyman merged commit 564662e into main Jul 30, 2026
2 checks passed
@wormeyman
wormeyman deleted the docs/ci-build-required branch July 30, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant