docs(ci): record the build job and the now-required build check - #66
Merged
Conversation
Three stale claims, all reading as current fact after #64/#65 merged: - verify.yml still listed `pnpm vp build` as deliberately absent, 90 lines above the job that runs it. - Its concurrency comment still said strict_required_status_checks_policy is false; ruleset EJ has had strict: true since before #65 landed. The reason main runs stay uncancelled survives, so it is corrected in place. - CLAUDE.md repeated the "build is absent" claim and the "build stamp reads git history" one that #64 measured wrong - it reads git *state*. Adds what happened after: `build` is a required check now, the two-step order for adding one (requiring a check that does not exist on main blocks the PR that introduces it), that the ruleset PUT replaces the whole rules array, and that strict: true means every other open PR needs Update branch after any merge. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BkKb3S2cGyRFFHSzuCQBgj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #64 and #65. Three claims went stale the moment those merged, and all three read as current fact:
verify.yml's header still listedpnpm vp buildunder "what is deliberately NOT here", 90 lines above the job that runs it.strict_required_status_checks_policyis false. RulesetEJhas hadstrict: truesince chore(renovate): automerge GitHub Action digest re-pins, and only those (#62) #65's prerequisite landed - which is the whole reason the automerge rule was safe to add. The rationale for not cancellingmainruns survives (a per-commit verdict onmainis still the thing that proves it), so it is corrected, not deleted.rev-parse HEAD,rev-parse --short HEAD,status --porcelain.Also records what actually happened after the merges:
buildis now a required check in rulesetEJ, added after ci(build): run pnpm vp build - verify never did (#61) #64 was green onmain. The table saysverify+build.mainblocks the PR that introduces it. Plus the PUT-replaces-rules gotcha, and thestrict: trueside effect that every other open PR needs Update branch after any merge.Docs and comments only - no workflow behaviour changes.