Lock file maintenance - #109
Merged
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wormeyman
added a commit
that referenced
this pull request
Sep 11, 2026
…tenance (#110) `npm ci` in src/vue failed on main with: npm error `npm ci` can only install packages when your package.json and package-lock.json are in sync. npm error Missing: tinyexec@1.3.0 from lock file Cause is the merge order, not either change. #109 (lock file maintenance) re-resolved the whole lockfile while vitest was still 4.1.11, and hoisted tinyexec 1.3.1 to the top level because 4.1.11 accepted it. #107 (vitest 5) was branched before that and merged after it. Git took both diffs without a textual conflict, but vitest 5.0.0 wants tinyexec 1.3.0, so the result named a dependency the lockfile no longer contained. The repair is one `npm install`: tinyexec moves from a hoisted node_modules/tinyexec at 1.3.1 to a nested node_modules/vitest/node_modules/ tinyexec at 1.3.0. Nothing else in the tree changes, and vitest is now the only consumer. CI would not have caught this. The "Build front-end" job runs `npm install`, which quietly repairs an out-of-sync lockfile in the runner and passes, so the committed lockfile stays broken for anyone using `npm ci`. Worth considering `npm ci` there instead, which is what a lockfile is for. Verified on this branch: `npm ci` exits 0, `npm audit` reports 0 vulnerabilities, `npm run build` passes, `vitest run` passes 51 of 51 on vitest 5.0.0, `npx eslint .` exits 0, and the committed FactorioToolsApi.ts does not drift. Claude-Session: https://claude.ai/code/session_01DAVZSEbjCkr9sbumdMPKy2 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: (in timezone America/Los_Angeles)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.