Repository navigation
fix(mlops): fix bind_simulation_device positional argument mismatch (… - #2270
Open
laasyapriya2007 wants to merge 1 commit into
Open
laasyapriya2007 wants to merge 1 commit into
laasyapriya2007 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2171.
Root Cause
In
python/fedml/core/mlops/__init__.py,bind_simulation_devicewas being invoked with three arguments (args,api_key,args.config_version), but the function was defined accepting only two (args,userid). This resulted in a runtime error:TypeError: bind_simulation_device() takes 2 positional arguments but 3 were given.Additionally, inside
bind_simulation_device, the local variable assignmentversion = fedml.get_env_version()shadowed any incoming version parameter.Solution
version="release"optional parameter tobind_simulation_device(args, userid, version="release"), making it compatible with both 2-argument and 3-argument callers.env_version = fedml.get_env_version()soargs.config_versioncorrectly uses the specified version when provided.getattr(args, "config_version", "release")before callingbind_simulation_deviceto prevent potentialAttributeErrorwhenargslacksconfig_version.