Skip to content

fix(auth): add username field to RegisterScreen (#318) #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tilakpatel22 merged 1 commit into from
Jul 25, 2026
Merged

fix(auth): add username field to RegisterScreen (#318) #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions fincept-qt/src/screens/auth/RegisterScreen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ RegisterScreen::RegisterScreen(QWidget* parent) : QWidget(parent) {
});
connect(&auth, &auth::AuthManager::otp_verified, this, [this]() {
verify_btn_->setEnabled(true);
for (QLineEdit* w :
{first_name_, last_name_, email_, phone_, country_code_, password_, confirm_pw_, otp_input_}) {
for (QLineEdit* w : {first_name_, last_name_, username_, email_, phone_, country_code_, password_,
confirm_pw_, otp_input_}) {
if (w)
w->clear();
}
Expand Down Expand Up @@ -249,6 +249,10 @@ void RegisterScreen::build_form_page() {
nrl->addLayout(ln_col);
vl->addWidget(name_row);

// Username is required by POST /user/register; do not invent it from the
// name fields (that hid the control and caused silent collisions — #318).
add_field(username_lbl_, username_, vl);

add_field(email_lbl_, email_, vl);

// Phone + country code side by side
Expand Down Expand Up @@ -436,6 +440,8 @@ void RegisterScreen::retranslateUi() {
first_name_lbl_->setText(tr("FIRST NAME"));
if (last_name_lbl_)
last_name_lbl_->setText(tr("LAST NAME"));
if (username_lbl_)
username_lbl_->setText(tr("USERNAME"));
if (email_lbl_)
email_lbl_->setText(tr("EMAIL"));
if (code_lbl_)
Expand All @@ -451,6 +457,8 @@ void RegisterScreen::retranslateUi() {
first_name_->setPlaceholderText(tr("First"));
if (last_name_)
last_name_->setPlaceholderText(tr("Last"));
if (username_)
username_->setPlaceholderText(tr("3-50 chars, letters/numbers/_"));
if (email_)
email_->setPlaceholderText(tr("user@domain.com"));
if (country_code_)
Expand Down Expand Up @@ -501,17 +509,30 @@ void RegisterScreen::on_register() {

QString fn = first_name_->text().trimmed();
QString ln = last_name_->text().trimmed();
QString username = auth::sanitize_input(username_->text()).toLower();
QString em = email_->text().trimmed();
QString ph = phone_->text().trimmed();
QString cc = country_code_->text().trimmed();
QString pw = password_->text();
QString cpw = confirm_pw_->text();

if (fn.isEmpty() || ln.isEmpty() || em.isEmpty() || ph.isEmpty() || pw.isEmpty() || cpw.isEmpty()) {
if (fn.isEmpty() || ln.isEmpty() || username.isEmpty() || em.isEmpty() || ph.isEmpty() || pw.isEmpty() ||
cpw.isEmpty()) {
error_label_->setText(tr("All fields are required"));
error_label_->show();
return;
}
if (username.length() < 3 || username.length() > 50) {
error_label_->setText(tr("Username must be 3-50 characters"));
error_label_->show();
return;
}
// Keep usernames URL/API-safe; spaces from names were a common failure mode.
if (!QRegularExpression(QStringLiteral("^[a-z0-9_]+$")).match(username).hasMatch()) {
error_label_->setText(tr("Username may only contain letters, numbers, and underscores"));
error_label_->show();
return;
}
if (cc.isEmpty()) {
error_label_->setText(tr("Country code is required (e.g. +1, +91)"));
error_label_->show();
Expand Down Expand Up @@ -539,13 +560,6 @@ void RegisterScreen::on_register() {
return;
}

QString username = auth::sanitize_input(fn + ln).toLower();
if (username.length() < 3 || username.length() > 50) {
error_label_->setText(tr("Username must be 3-50 characters"));
error_label_->show();
return;
}

register_btn_->setEnabled(false);
register_btn_->setText(tr(" CREATING... "));
auth::AuthManager::instance().signup(username, em, pw, ph, {}, cc);
Expand All @@ -565,9 +579,7 @@ void RegisterScreen::on_verify_otp() {
}

void RegisterScreen::on_resend_otp() {
QString fn = first_name_->text().trimmed();
QString ln = last_name_->text().trimmed();
QString username = auth::sanitize_input(fn + ln).toLower();
QString username = auth::sanitize_input(username_->text()).toLower();
QString cc = country_code_->text().trimmed();
if (!cc.isEmpty() && !cc.startsWith('+'))
cc = '+' + cc;
Expand Down
2 changes: 2 additions & 0 deletions fincept-qt/src/screens/auth/RegisterScreen.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class RegisterScreen : public QWidget {
QLabel* form_title_ = nullptr;
QLabel* first_name_lbl_ = nullptr;
QLabel* last_name_lbl_ = nullptr;
QLabel* username_lbl_ = nullptr;
QLabel* email_lbl_ = nullptr;
QLabel* code_lbl_ = nullptr;
QLabel* phone_lbl_ = nullptr;
Expand All @@ -40,6 +41,7 @@ class RegisterScreen : public QWidget {

QLineEdit* first_name_ = nullptr;
QLineEdit* last_name_ = nullptr;
QLineEdit* username_ = nullptr;
QLineEdit* email_ = nullptr;
QLineEdit* phone_ = nullptr;
QLineEdit* country_code_ = nullptr;
Expand Down
Loading