Fix asset search dropdown overlap, clipping, and vertical scrollbar - #361
Merged
tilakpatel22 merged 1 commit intoJul 25, 2026
Merged
Conversation
Contributor
|
Hi @Sujallukhi04 — thanks for the PR! Our automated scope gate flagged the following: ❌ No scope-approved linked issue. This PR must close an issue that carries one of: Please read CONTRIBUTING.md. Once an issue with the appropriate label exists and is linked here, re-run this check by pushing an empty commit or editing the PR description. A maintainer can also bypass this gate by adding the PRs that remain unresolved for 7 days will be closed automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope gate (required)
good-first-issue,help-wanted, orscope:approvedlabel.mainon my fork).Fixes #361
What does this PR do?
Fixes the "Add Asset" dialog's ticker search suggestions dropdown rendering transparently, bleeding background elements, and getting clipped by the dialog's boundaries. It also caps the visible list height at 6 items and displays a custom scrollbar for overflow items.
Type of change
Changes made
fincept-qt/src/screens/portfolio/PortfolioDialogs.h: Included<QMoveEvent>and declared themoveEvent()override.fincept-qt/src/screens/portfolio/PortfolioDialogs.cpp:search_frame_as a top-levelQt::Toolwindow to bypass dialog boundary clipping and layout rendering collisions.search_list_.search_list_for a correct widget hierarchy.qApp->focusChanged.position_dropdown()using global coordinates.moveEvent()to update coordinates dynamically if the dialog is dragged on screen.How to test
AA) into the Symbol field to trigger the suggestion list.Architecture / code-quality checklist
waitForFinished()on main thread) — see CLAUDE.md P1showEvent()/hideEvent()— see P3QProcessfor Python — usedPythonRunner::instance().run()— see P4print()in Python scripts — usedlogger.info/logger.warning— see P14Screenshots / logs
Before:
After: