fix: strip inline SMV comments (from vent parser, improve log_error

_load_vents failed with 'could not convert string to float: !' on FDS
6.9.0+ output. Starting with FDS 6.9.0, the SMV writer appends an inline
obstruction reference as a comment to non-dummy vent lines in the second
pass (e.g. '13 15 0 0 99 0 ! 3'). Fixed by stripping everything from '!'
onward before tokenizing in read_common_info and read_common_info2.
Also improved log_error decorator: full traceback is now included in the
warning output (exc_info=True) so errors are no longer silently swallowed.
Removed unused sys import.
Fixes #109, #90, #82.

Author: m-fehr

fdsreader/simulation.py

@@ -475,11 +475,13 @@ def _load_vents(self, smv_file: TextIO, mesh: Mesh):
         temp_data = list()
 
         def read_common_info():
-            line = smv_file.readline().strip().split()
+            # Strip inline FDS comments (everything from '!' onward) before parsing
+            line = smv_file.readline().split("!")[0].strip().split()
             return line, [float(line[i]) for i in range(6)], int(line[6]) - 1, self.surfaces[int(line[7])]
 
         def read_common_info2():
-            line = smv_file.readline().strip().split()
+            # Strip inline FDS comments (everything from '!' onward) before parsing
+            line = smv_file.readline().split("!")[0].strip().split()
             bound_indices = tuple(int(line[i]) for i in range(6))
             color_index = int(line[6])
             draw_type = int(line[7])

fdsreader/utils/misc.py

@@ -1,5 +1,4 @@
 import logging
-import sys
 from functools import wraps
 
 from fdsreader import settings
@@ -14,14 +13,15 @@ def wrapped(*args, **kwargs):
             except Exception as e:
                 if settings.DEBUG:
                     raise e
-                elif not settings.IGNORE_ERRORS:
-                    e = type(e)(
-                        f"Module {str(module)}: {str(e)}\nThe error can be safely ignored if not requiring the"
-                        f" {str(module)} module. However, please consider to submit an issue on Github including"
-                        f" the error message, the stack trace and your FDS input-file so we can reproduce the"
-                        f" error and fix it as soon as possible!"
-                    ).with_traceback(sys.exc_info()[2])
-                    logging.warning(e)
+                else:
+                    msg = (
+                        f"Module {str(module)}: {str(e)}\n"
+                        f"The error can be safely ignored if not requiring the {str(module)} module.\n"
+                        f"Please consider submitting an issue on GitHub including the error message,\n"
+                        f"the stack trace and your FDS input-file so we can reproduce and fix it."
+                    )
+                    if not settings.IGNORE_ERRORS:
+                        logging.warning(msg, exc_info=True)
 
         return wrapped