Repository navigation
Commit 21492b4
committed
fix: do not read CI's version stamp as a release bump
CI stamps an experimental version into package.json before packing, so
the gate sees `4.2.6-exp.<sha>` while 4.2.6 is published. Two comparisons
assumed the candidate and the published release would be identical
outside a real release, and both were wrong in CI.
The version rule compared version strings. Since the stamped version is
never equal to the published one, every pull-request build read as a
release candidate, and since the numeric core matches, as a patch bump.
The first pull request to legitimately change the type surface would have
failed with a version error unrelated to the change. It compares the
numeric core now, so a stamped build of the published version is not a
release while a genuine bump, including its prereleases, still is.
The size acknowledgment compared recorded byte counts exactly. Those
numbers come from `gate:accept` run locally and are checked against a CI
build, which the stamp alone makes differ (measured ~+0.5% on the
tarball), so no acknowledgment would ever have applied in CI and an
intended size change could not be landed at all. Recorded sizes are now
matched within the existing tolerance, with the entry set still required
to agree so an acknowledgment cannot silently cover a new entry point.
Neither surfaced on this branch because the type surface is currently
identical to 4.2.6, so the checks returned before reaching either
comparison. Found by reading the CI log rather than from a failure.
Tests go 64 to 69, covering the stamped-version case, a prerelease of a
genuine bump in both directions, and acknowledgment matching at CI-sized
drift, beyond tolerance, and across a changed entry set.1 parent b9b12a8 commit 21492b4
3 files changed
Lines changed: 131 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
138 | 148 | | |
139 | 149 | | |
140 | 150 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
271 | 292 | | |
272 | 293 | | |
273 | 294 | | |
| |||
613 | 634 | | |
614 | 635 | | |
615 | 636 | | |
616 | | - | |
| 637 | + | |
617 | 638 | | |
618 | 639 | | |
619 | 640 | | |
| |||
641 | 662 | | |
642 | 663 | | |
643 | 664 | | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
644 | 684 | | |
645 | 685 | | |
646 | 686 | | |
| |||
657 | 697 | | |
658 | 698 | | |
659 | 699 | | |
660 | | - | |
661 | | - | |
662 | | - | |
663 | | - | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
664 | 708 | | |
665 | 709 | | |
666 | 710 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
417 | 419 | | |
418 | 420 | | |
419 | 421 | | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
420 | 462 | | |
421 | 463 | | |
422 | 464 | | |
| |||
483 | 525 | | |
484 | 526 | | |
485 | 527 | | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
486 | 554 | | |
487 | 555 | | |
488 | 556 | | |
| |||
0 commit comments