Repository navigation
Commit 4c3270c
committed
fix(deps): require use-sync-external-store ^1.5.0 so the ESM build loads in Node
dist/index.js imports `use-sync-external-store/shim`, which is kept
external. Before 1.5.0 the package had no `exports` map, so Node's ESM
resolver treats `/shim` as a directory and throws
ERR_UNSUPPORTED_DIR_IMPORT. That breaks anything that loads the ESM build
without a bundler: Vitest tests in apps that use reactfire, SSR that keeps
dependencies external, and plain Node scripts. The CJS build is fine.
Raise the floor to ^1.5.0 (lockfile: 1.2.0 -> 1.7.0), and add a build
job step that loads the built package with Node as both ESM and CJS so
this can't regress unnoticed.1 parent 711828c commit 4c3270c
3 files changed
Lines changed: 13 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
40 | 46 | | |
41 | 47 | | |
42 | 48 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| |||
0 commit comments